From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marius Bakke Subject: Re: [PATCH 6/6] gnu: Add grub-efi. Date: Mon, 07 Nov 2016 00:19:48 +0000 Message-ID: <87vaw087kr.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> References: <20161105125511.29383-1-mbakke@fastmail.com> <20161105125511.29383-7-mbakke@fastmail.com> <20161105185803.GA11667@jasmine> <87h97l67kz.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> <878tsww9ov.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:42376) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c3XfN-0008SQ-9s for guix-devel@gnu.org; Sun, 06 Nov 2016 19:20:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c3XfK-0004ye-3V for guix-devel@gnu.org; Sun, 06 Nov 2016 19:20:01 -0500 In-Reply-To: <878tsww9ov.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: guix-devel@gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > Marius Bakke skribis: > >> Leo Famulari writes: >> >>> On Sat, Nov 05, 2016 at 12:55:11PM +0000, Marius Bakke wrote: >>>> * gnu/packages/grub.scm (grub-efi): New variable. >>>> --- >>>> gnu/packages/grub.scm | 21 +++++++++++++++++++++ >>>> 1 file changed, 21 insertions(+) >>>>=20 >>>> diff --git a/gnu/packages/grub.scm b/gnu/packages/grub.scm >>>> index ffce1bf..e06216f 100644 >>>> --- a/gnu/packages/grub.scm >>>> +++ b/gnu/packages/grub.scm >>>> @@ -157,3 +157,24 @@ on the same computer; upon booting the computer, = the user is presented with a >>>> menu to select one of the installed operating systems.") >>>> (license gpl3+) >>>> (properties '((cpe-name . "grub2"))))) >>>> + >>>> +(define-public grub-efi >>>> + (package >>>> + (inherit grub) >>>> + (name "grub-efi") >>>> + (synopsis (string-append (package-synopsis grub) " (UEFI version)= ")) >>>> + (inputs >>>> + `(("efibootmgr" ,efibootmgr) >>>> + ,@(package-inputs grub))) >>>> + (arguments >>>> + #:tests? #f ; FIXME: 40 failures, 24 skipped, 17 passed. >>> >>> Does this package work for you? >> >> Oops, not sure what went wrong when fixing up this package for >> publishing. Updated patch attached. > > I think Leo was asking whether you could get a bootable system with it. Yes, I'm using this right now, on top of the recent changes to "guix system" :) There are a couple of other changes necessary for proper UEFI support: the grub-install command needs "--efi-directory=3D" and optionally "--bootloader-id=3DGNU" (I use these as well, but did not publish them, since I haven't tested it on a BIOS system yet, and they probably need to be conditional somehow).=20 >> From 940c03c7dcddec019e27f6eb1470aeab4db57799 Mon Sep 17 00:00:00 2001 >> From: Marius Bakke >> Date: Thu, 20 Oct 2016 17:26:52 +0100 >> Subject: [PATCH] gnu: Add grub-efi. >> >> * gnu/packages/grub.scm (grub-efi): New variable. > > [...] > >> + (name "grub-efi") >> + (synopsis (string-append (package-synopsis grub) " (UEFI version)")) > > Please use a literal string for =E2=80=98synopsis=E2=80=99; use of =E2=80= =98string-append=E2=80=99 like > this prevents i18n. > >> + `(#:tests? #f ; FIXME: 40 failures, 24 skipped, 17 passed. > > It would be good to investigate, especially if the tests pass in the > =E2=80=98grub=E2=80=99 package. > > Also, what=E2=80=99s the rationale for making =E2=80=98grub-efi=E2=80=99 = separate instead of > incorporating the changes in =E2=80=98grub=E2=80=99 proper? Are there is= sues around the > portability of =E2=80=98efibootmgr=E2=80=99, or an increased closure size? This is a good point. The only difference with "--with-platform=3Defi" is that another directory is created in place of the i386-pc directory. It is perfectly possible to build multiple platforms and copying the platform-specific stuff to $out/lib -- grub will pick the correct platform at runtime. This is what the Gentoo ebuild does. I'll give this a shot and send an updated patch later this week. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBCgAGBQJYH8ilAAoJEKKgbfKjOlT6NZQIAJgLoYmvqYeFHkSrBiM+cUoE 8awBz2YkHlXprb9xcukMnlLI38wWJaV5V+YgM9QuS1irE1XCyx/yjEGfzr1xQdg9 7khCfnggTuH66fJQOgOflFLzPsiYS2rtjNKtx/wW2cdi9aqHyQ7EKtwpVgiqicYN NmVmQisfMF+4MGoztIV73d+e6ZYVfBC8d7oG/yuL3Ihy33s3GEx+nN9+8ucBWY0N YGSoNWWp4zozDF3eklnjC37f7w5/6YzN5vl8XLP7+hMyKcBhlVpvCOkqqsbVD6pf a7RbzqBJ+JD1yGTD/RzObsF1vXpmsj2RAvDRfC1o7iUN0P/WM/BngoIqFs3UiA0= =nPHZ -----END PGP SIGNATURE----- --=-=-=--