From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marius Bakke Subject: Re: [PATCH] gnu: Add espeak. Date: Tue, 22 Nov 2016 16:01:30 +0100 Message-ID: <87vavf5zjp.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> References: <87fumktptd.fsf@openmailbox.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:40090) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c9CZl-0000Uh-Ky for guix-devel@gnu.org; Tue, 22 Nov 2016 10:01:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c9CZh-0007XY-Ni for guix-devel@gnu.org; Tue, 22 Nov 2016 10:01:37 -0500 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:51313) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c9CZh-0007W8-JV for guix-devel@gnu.org; Tue, 22 Nov 2016 10:01:33 -0500 In-Reply-To: <87fumktptd.fsf@openmailbox.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Kei Kebreau , guix-devel@gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Kei Kebreau writes: > I think the patch works fine, but I'd love to hear comments about its > clarity. Hi! Thanks for this patch. The source includes a pre-compiled 32-bit version in "linux_32bit". Can you remove that with a source snippet? > From d1031c30c57eb6f292a91963801f87b419d8bee2 Mon Sep 17 00:00:00 2001 > From: Kei Kebreau > Date: Mon, 21 Nov 2016 17:35:00 -0500 > Subject: [PATCH] gnu: Add espeak. >=20 > * gnu/packages/audio.scm (espeak): New variable. > --- > gnu/packages/audio.scm | 46 ++++++++++++++++++++++++++++++++++++++++++++= ++ > 1 file changed, 46 insertions(+) >=20 > diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm > index 77d3b53..8aba416 100644 > --- a/gnu/packages/audio.scm > +++ b/gnu/packages/audio.scm > @@ -343,6 +343,52 @@ tools (analyzer, mono/stereo tools, crossovers).") > ;; The plugins are released under LGPLv2.1+ > (license (list license:lgpl2.1+ license:gpl2+)))) >=20=20 > +(define-public espeak > + (package > + (name "espeak") > + (version "1.48.04") > + (source (origin > + (method url-fetch) > + (uri (string-append "mirror://sourceforge/espeak/espeak-1.= 48/" Two comments: The URL should be "mirror://sourceforge/espeak/espeak/espeak-1.48" (note the extra "espeak"). In addition, you can use the "version-major+minor" procedure instead of hard coding "1.48" here. Other than that this LGTM! > + "espeak-" version "-source.zip")) > + (sha256 > + (base32 > + "0n86gwh9pw0jqqpdz7mxggllfr8k0r7pc67ayy7w5z6z79kig6mz"))= )) > + (build-system gnu-build-system) > + (arguments > + `(#:make-flags (list (string-append "PREFIX=3D" (assoc-ref %outputs= "out")) > + (string-append "DATADIR=3D" > + (assoc-ref %outputs "out") > + "/share/espeak-data") > + (string-append "LDFLAGS=3D-Wl,-rpath=3D" > + (assoc-ref %outputs "out") > + "/lib") > + "AUDIO=3Dpulseaudio") > + #:tests? #f ; no check target > + #:phases > + (modify-phases %standard-phases > + (replace 'configure > + (lambda _ > + (chdir "src") > + ;; We use version 19 of the PortAudio library, so we must c= opy the > + ;; corresponding file to be sure that espeak compiles corre= ctly. > + (copy-file "portaudio19.h" "portaudio.h") > + (substitute* "Makefile" > + (("/bin/ln") "ln")) > + #t))))) > + (inputs > + `(("portaudio" ,portaudio) > + ("pulseaudio" ,pulseaudio))) > + (native-inputs `(("unzip" ,unzip))) > + (home-page "http://espeak.sourceforge.net/") > + (synopsis "Software speech synthesizer") > + (description "eSpeak is a software speech synthesizer for English= and > +other languages. eSpeak uses a \"formant synthesis\" method. This allo= ws many > +languages to be provided in a small size. The speech is clear, and can = be used > +at high speeds, but is not as natural or smooth as larger synthesizers w= hich are > +based on human speech recordings.") > + (license license:gpl3+))) > + > (define-public infamous-plugins > (package > (name "infamous-plugins") > --=20 > 2.10.2 >=20 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBCgAGBQJYNF3KAAoJEKKgbfKjOlT6HdoH/3uJfmMEEForvGNcJC8JmQQB c97yjdjAEEADSVJKLukhM2nz0EVEvttVMV42M3eswMNJ+bdMpuAxrGQ9gX0LFzh8 yihGLWsIf4Xbe3OM8bS6rZgrXOTzWpGfge9G4xp+l84/mSRFGymMpba1yEXI4Wjs qtdAtbGLW1N/k5GWmjfCIMdTgqgFVUTmZ2LDQ4ExydsfQzm3g5BAQFa0AnkBWFu7 hmsRSrzFSvqLIJfIHkZsCz1PcUihVfOXteMBeRMsxjU7V0t0CROlCt+hqrux+C/B H6jUP9ii3IPzr5MFa8MnnvA2xVtrtyk4WeY9IlUw6DRgeYfXmnu46QeLhEjTp2I= =L1/T -----END PGP SIGNATURE----- --=-=-=--