* Re: 01/01: gnu: python-pyopenssl: Disable tests. [not found] ` <20161214173804.3FE492201BA@vcs.savannah.gnu.org> @ 2016-12-15 23:49 ` Leo Famulari 2016-12-16 13:21 ` Marius Bakke 0 siblings, 1 reply; 4+ messages in thread From: Leo Famulari @ 2016-12-15 23:49 UTC (permalink / raw) To: guix-devel On Wed, Dec 14, 2016 at 05:38:04PM +0000, Marius Bakke wrote: > mbakke pushed a commit to branch python-tests > in repository guix. > > commit 30e0229a1713e77dc0397dfb4ee6af4ac6a00443 > Author: Marius Bakke <mbakke@fastmail.com> > Date: Wed Dec 14 18:34:48 2016 +0100 > > gnu: python-pyopenssl: Disable tests. > > * gnu/packages/python.scm (python-pyopenssl, python2-pyopenssl)[arguments]: > Set #:tests? #f. > [native-inputs]: Add python-pytest. > --- > gnu/packages/python.scm | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm > index cd6ed1c..ebe0194 100644 > --- a/gnu/packages/python.scm > +++ b/gnu/packages/python.scm > @@ -6585,11 +6585,16 @@ message digests and key derivation functions.") > (base32 > "0vji4yrfshs15xpczbhzhasnjrwcarsqg87n98ixnyafnyxs6ybp")))) > (build-system python-build-system) > + (arguments > + ;; FIXME: Some tests fail with "NameError: name 'long' is not defined". > + '(#:tests? #f)) Do you think this indicates a real problem? Or is the issue limited to the tests? ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: 01/01: gnu: python-pyopenssl: Disable tests. 2016-12-15 23:49 ` 01/01: gnu: python-pyopenssl: Disable tests Leo Famulari @ 2016-12-16 13:21 ` Marius Bakke 2016-12-16 20:20 ` Leo Famulari 0 siblings, 1 reply; 4+ messages in thread From: Marius Bakke @ 2016-12-16 13:21 UTC (permalink / raw) To: Leo Famulari, guix-devel [-- Attachment #1: Type: text/plain, Size: 1738 bytes --] Leo Famulari <leo@famulari.name> writes: > On Wed, Dec 14, 2016 at 05:38:04PM +0000, Marius Bakke wrote: >> mbakke pushed a commit to branch python-tests >> in repository guix. >> >> commit 30e0229a1713e77dc0397dfb4ee6af4ac6a00443 >> Author: Marius Bakke <mbakke@fastmail.com> >> Date: Wed Dec 14 18:34:48 2016 +0100 >> >> gnu: python-pyopenssl: Disable tests. >> >> * gnu/packages/python.scm (python-pyopenssl, python2-pyopenssl)[arguments]: >> Set #:tests? #f. >> [native-inputs]: Add python-pytest. >> --- >> gnu/packages/python.scm | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm >> index cd6ed1c..ebe0194 100644 >> --- a/gnu/packages/python.scm >> +++ b/gnu/packages/python.scm >> @@ -6585,11 +6585,16 @@ message digests and key derivation functions.") >> (base32 >> "0vji4yrfshs15xpczbhzhasnjrwcarsqg87n98ixnyafnyxs6ybp")))) >> (build-system python-build-system) >> + (arguments >> + ;; FIXME: Some tests fail with "NameError: name 'long' is not defined". >> + '(#:tests? #f)) > > Do you think this indicates a real problem? Or is the issue limited to > the tests? I dug a bit further into this, and the problem is likely that PYTHONPATH is incomplete at test time. Moving 'check after 'install and adding a proper PYTHONPATH seems to work, but now I ran into a test needing network access. https://github.com/pyca/pyopenssl/blob/16.2.0/tests/test_ssl.py#L1186 I'll prepare a patch to remove that test entirely, unless someone knows a clever way to check for network access and conditionally skip it (which I'm sure upstream would be happy to accept). [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 487 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: 01/01: gnu: python-pyopenssl: Disable tests. 2016-12-16 13:21 ` Marius Bakke @ 2016-12-16 20:20 ` Leo Famulari 2016-12-16 20:22 ` Marius Bakke 0 siblings, 1 reply; 4+ messages in thread From: Leo Famulari @ 2016-12-16 20:20 UTC (permalink / raw) To: Marius Bakke; +Cc: guix-devel [-- Attachment #1: Type: text/plain, Size: 996 bytes --] On Fri, Dec 16, 2016 at 02:21:47PM +0100, Marius Bakke wrote: > Leo Famulari <leo@famulari.name> writes: > > On Wed, Dec 14, 2016 at 05:38:04PM +0000, Marius Bakke wrote: > >> + (arguments > >> + ;; FIXME: Some tests fail with "NameError: name 'long' is not defined". > >> + '(#:tests? #f)) > > > > Do you think this indicates a real problem? Or is the issue limited to > > the tests? > > I dug a bit further into this, and the problem is likely that PYTHONPATH > is incomplete at test time. Moving 'check after 'install and adding a > proper PYTHONPATH seems to work, but now I ran into a test needing > network access. > > https://github.com/pyca/pyopenssl/blob/16.2.0/tests/test_ssl.py#L1186 > > I'll prepare a patch to remove that test entirely, unless someone knows > a clever way to check for network access and conditionally skip it > (which I'm sure upstream would be happy to accept). I think it's fine to simply skip or remove that test. Thanks! [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: 01/01: gnu: python-pyopenssl: Disable tests. 2016-12-16 20:20 ` Leo Famulari @ 2016-12-16 20:22 ` Marius Bakke 0 siblings, 0 replies; 4+ messages in thread From: Marius Bakke @ 2016-12-16 20:22 UTC (permalink / raw) To: Leo Famulari; +Cc: guix-devel [-- Attachment #1: Type: text/plain, Size: 1119 bytes --] Leo Famulari <leo@famulari.name> writes: > On Fri, Dec 16, 2016 at 02:21:47PM +0100, Marius Bakke wrote: >> Leo Famulari <leo@famulari.name> writes: >> > On Wed, Dec 14, 2016 at 05:38:04PM +0000, Marius Bakke wrote: >> >> + (arguments >> >> + ;; FIXME: Some tests fail with "NameError: name 'long' is not defined". >> >> + '(#:tests? #f)) >> > >> > Do you think this indicates a real problem? Or is the issue limited to >> > the tests? >> >> I dug a bit further into this, and the problem is likely that PYTHONPATH >> is incomplete at test time. Moving 'check after 'install and adding a >> proper PYTHONPATH seems to work, but now I ran into a test needing >> network access. >> >> https://github.com/pyca/pyopenssl/blob/16.2.0/tests/test_ssl.py#L1186 >> >> I'll prepare a patch to remove that test entirely, unless someone knows >> a clever way to check for network access and conditionally skip it >> (which I'm sure upstream would be happy to accept). > > I think it's fine to simply skip or remove that test. Way ahead of you: 7c6bf660d8a455090f4c140c5b2849f1b58f2fe3 :-) [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 487 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-12-16 20:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20161214173803.7999.79849@vcs.savannah.gnu.org>
[not found] ` <20161214173804.3FE492201BA@vcs.savannah.gnu.org>
2016-12-15 23:49 ` 01/01: gnu: python-pyopenssl: Disable tests Leo Famulari
2016-12-16 13:21 ` Marius Bakke
2016-12-16 20:20 ` Leo Famulari
2016-12-16 20:22 ` Marius Bakke
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/guix.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).