unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Marius Bakke <mbakke@fastmail.com>
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel@gnu.org
Subject: Re: 01/01: gnu: python-pyopenssl: Disable tests.
Date: Fri, 16 Dec 2016 21:22:48 +0100	[thread overview]
Message-ID: <87vauj8vzb.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> (raw)
In-Reply-To: <20161216202009.GK20488@jasmine>

[-- Attachment #1: Type: text/plain, Size: 1119 bytes --]

Leo Famulari <leo@famulari.name> writes:

> On Fri, Dec 16, 2016 at 02:21:47PM +0100, Marius Bakke wrote:
>> Leo Famulari <leo@famulari.name> writes:
>> > On Wed, Dec 14, 2016 at 05:38:04PM +0000, Marius Bakke wrote:
>> >> +    (arguments
>> >> +     ;; FIXME: Some tests fail with "NameError: name 'long' is not defined".
>> >> +     '(#:tests? #f))
>> >
>> > Do you think this indicates a real problem? Or is the issue limited to
>> > the tests?
>> 
>> I dug a bit further into this, and the problem is likely that PYTHONPATH
>> is incomplete at test time. Moving 'check after 'install and adding a
>> proper PYTHONPATH seems to work, but now I ran into a test needing
>> network access.
>> 
>> https://github.com/pyca/pyopenssl/blob/16.2.0/tests/test_ssl.py#L1186
>> 
>> I'll prepare a patch to remove that test entirely, unless someone knows
>> a clever way to check for network access and conditionally skip it
>> (which I'm sure upstream would be happy to accept).
>
> I think it's fine to simply skip or remove that test.

Way ahead of you: 7c6bf660d8a455090f4c140c5b2849f1b58f2fe3 :-)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

      reply	other threads:[~2016-12-16 20:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20161214173803.7999.79849@vcs.savannah.gnu.org>
     [not found] ` <20161214173804.3FE492201BA@vcs.savannah.gnu.org>
2016-12-15 23:49   ` 01/01: gnu: python-pyopenssl: Disable tests Leo Famulari
2016-12-16 13:21     ` Marius Bakke
2016-12-16 20:20       ` Leo Famulari
2016-12-16 20:22         ` Marius Bakke [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vauj8vzb.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me \
    --to=mbakke@fastmail.com \
    --cc=guix-devel@gnu.org \
    --cc=leo@famulari.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).