From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marius Bakke Subject: Re: [PATCH] guix: python-build-system: Properly inform caller about test status. Date: Thu, 05 Jan 2017 14:31:41 +0100 Message-ID: <87vatty6o2.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> References: <20170104233058.4068-1-dannym@scratchpost.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:36272) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cP88z-0003Z9-Dh for guix-devel@gnu.org; Thu, 05 Jan 2017 08:31:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cP88u-0003Xk-LW for guix-devel@gnu.org; Thu, 05 Jan 2017 08:31:49 -0500 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:42999) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cP88u-0003Xc-C3 for guix-devel@gnu.org; Thu, 05 Jan 2017 08:31:44 -0500 In-Reply-To: <20170104233058.4068-1-dannym@scratchpost.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Danny Milosavljevic , guix-devel@gnu.org --=-=-= Content-Type: text/plain Danny Milosavljevic writes: > * guix/build/python-build-system.scm (check): Properly inform caller about test status. > --- > guix/build/python-build-system.scm | 13 +++++++------ > 1 file changed, 7 insertions(+), 6 deletions(-) > > diff --git a/guix/build/python-build-system.scm b/guix/build/python-build-system.scm > index 3f280b0ac..d46739827 100644 > --- a/guix/build/python-build-system.scm > +++ b/guix/build/python-build-system.scm > @@ -136,12 +136,13 @@ > ;; build/lib in some cases, e.g. if the source is in a sub-directory > ;; (given with `package_dir`). This will by copied to the output, too, > ;; so we need to remove. > - (let ((before (find-files "build" "\\.egg-info$" #:directories? #t))) > - (call-setuppy test-target '() use-setuptools?) > - (let* ((after (find-files "build" "\\.egg-info$" #:directories? #t)) > - (inter (lset-difference eqv? after before))) > - (for-each delete-file-recursively inter))) > - #t)) > + (let* ((before (find-files "build" "\\.egg-info$" #:directories? #t)) > + (status (call-setuppy test-target '() use-setuptools?)) > + (after (find-files "build" "\\.egg-info$" #:directories? #t)) > + (inter (lset-difference eqv? after before))) > + (for-each delete-file-recursively inter) > + status) > + #t)) This is fixed with e46a043ecd9f9ef46d1d44393362bb7016454544 from the 'python-tests' branch. Speaking of which, there are still some failing packages in that branch listed at: https://hydra.gnu.org/eval/109407?compare=master#tabs-now-fail I'll try to take care of the remaining failures in the next week so we can merge this branch. Contributions are always welcome however ;-) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlhuSr0ACgkQoqBt8qM6 VPr9IAf/TydU17vapsoaaLSKT5HXj+/1adCu6AyEhFKLzK+LyB9ObcAV1sQA30bz VTvUiodmquzYlowftgsnL7DsLGFAfT9UKw9VerZCmKl4ZX6R66Q/7BFSBxw8u5uw A5LDC4yrVFHl5DBcGI1W3tKgjF55Bb1fBdymertxIYTdQGK2Up0nmk4oRfZqwolL KaqHcATga0XiZJzHE6l1gr085UXgcukRoytOCjO29Jvp3uTwAd7HpnZWG7B7wrj7 FpRNIxTwOj5qCsr7GSbBSVBdnaFgAMb/VH6Jl5stiTdi1YFQEr6RcMlgj391mNGm 6G2cJ6YROfa6SUrrjGTBbMmdZ/hBbw== =ap6V -----END PGP SIGNATURE----- --=-=-=--