Re: [PATCH] guix: python-build-system: Properly inform caller about test status.

[Marius Bakke <mbakke@fastmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1788 bytes --]

Danny Milosavljevic <dannym@scratchpost.org> writes:

> * guix/build/python-build-system.scm (check): Properly inform caller about test status.
> ---
>  guix/build/python-build-system.scm | 13 +++++++------
>  1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/guix/build/python-build-system.scm b/guix/build/python-build-system.scm
> index 3f280b0ac..d46739827 100644
> --- a/guix/build/python-build-system.scm
> +++ b/guix/build/python-build-system.scm
> @@ -136,12 +136,13 @@
>        ;; build/lib in some cases, e.g. if the source is in a sub-directory
>        ;; (given with `package_dir`). This will by copied to the output, too,
>        ;; so we need to remove.
> -      (let ((before (find-files "build" "\\.egg-info$" #:directories? #t)))
> -        (call-setuppy test-target '() use-setuptools?)
> -        (let* ((after (find-files "build" "\\.egg-info$" #:directories? #t))
> -               (inter (lset-difference eqv? after before)))
> -          (for-each delete-file-recursively inter)))
> -    #t))
> +      (let* ((before (find-files "build" "\\.egg-info$" #:directories? #t))
> +             (status (call-setuppy test-target '() use-setuptools?))
> +             (after (find-files "build" "\\.egg-info$" #:directories? #t))
> +             (inter (lset-difference eqv? after before)))
> +        (for-each delete-file-recursively inter)
> +        status)
> +      #t))

This is fixed with e46a043ecd9f9ef46d1d44393362bb7016454544 from the
'python-tests' branch. Speaking of which, there are still some failing
packages in that branch listed at:
https://hydra.gnu.org/eval/109407?compare=master#tabs-now-fail

I'll try to take care of the remaining failures in the next week so we
can merge this branch. Contributions are always welcome however ;-)


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]