From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marius Bakke Subject: Re: [PATCH] gnu: add geos Date: Sat, 21 Jan 2017 14:08:12 +0100 Message-ID: <87vat85znn.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> References: <20170120183531.7ec19200@alma-ubu> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:41630) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cUvP4-00039o-9O for guix-devel@gnu.org; Sat, 21 Jan 2017 08:08:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cUvP1-0003lU-1e for guix-devel@gnu.org; Sat, 21 Jan 2017 08:08:22 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:39391) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cUvP0-0003lD-Rh for guix-devel@gnu.org; Sat, 21 Jan 2017 08:08:18 -0500 In-Reply-To: <20170120183531.7ec19200@alma-ubu> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: =?utf-8?Q?Bj=C3=B6rn_H=C3=B6fling?= , guix-devel@gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Bj=C3=B6rn H=C3=B6fling writes: > * gnu/packages/geo.scm (geos): New variable. Thanks for this! I've applied it with some minor changes, described below: > +(define-public geos > + (package > + (name "geos") > + (version "3.6.1") > + (source (origin > + (method url-fetch) > + (uri (string-append "http://download.osgeo.org/geos/geos-" > + version > + ".tar.bz2")) > + (sha256 > + (base32 > + "1icz31kd5sml2kdxhjznvmv33zfr6nig9l0i6bdcz9q9g8x4wbja"))= )) > + (build-system gnu-build-system) > + (arguments `(#:phases > + (modify-phases %standard-phases > + (add-after > + 'unpack 'patch-test-shebangs > + (lambda _ > + (substitute* '("tests/xmltester/testrunner.sh" > + "tests/geostest/testrunner.sh") > + (("/bin/sh") (which "bash"))) Bash behaves differently based on whether it's invoked as 'bash' or 'sh', so I changed this to (which "sh") to be safe. > + #t))))) > + (inputs > + `(("glib" ,glib))) > + (home-page "https://geos.osgeo.org/") > + (synopsis "Geometry Engine - Open Source") We try to avoid terms like "open source" or "free software" since it's implied in the context of Guix. > + (description > + "GEOS (Geometry Engine - Open Source) is a C++ port of the > +Java Topology Suite (JTS). As such, it aims to contain the complete > +functionality of JTS in C++. This includes all the OpenGIS Simple Featu= res > +for SQL spatial predicate functions and spatial operators, > +as well as specific JTS enhanced topology functions.") I took inspiration from Debians description of this package and tweaked it a little. > + (license license:lgpl2.1))) The files do not mention whether it's 2.1 only or later versions so we default to "or later". Also found a few files with other licenses. Pushed as 252611c7c4e72577cd0c91a41e10176f37ac318b ! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAliDXTwACgkQoqBt8qM6 VPohZQf/Zg1PGAJtECVY3xpsQl4loZAELFNtngDQtpV8tOnHXYS0EAdt4xGZCZoz 1WmJrK299qJmgYHEuzBMe54HvS6vbEg5WylgiB3/27IWC9U2Ikt/KYAL69+Unh3R 1E1yqHSG1/lLUj4hxCHAvCsjH+C8x7xt/yUg5zlPSU2AaBRawA9ORHHB5VaPHF9x OZk7E3zrAGSSzCC7zJvUVoN+ckHaAHFH6TFrb/RE+XOCr4bj0AxcE6pUMiT0RC6l 4na7cnceKFpfy976AcIlskp3VlIOdZiJhcwKdWm4CT5AY9gpMnDNIQdPD7lkOuVN xT36MU60Qa2+96bVGeYyW5nyvuwQhQ== =Kmat -----END PGP SIGNATURE----- --=-=-=--