From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: dub: Patch pkg-config name.
Date: Fri, 03 Feb 2017 17:49:38 +0100
Message-ID: <87vasr9q3h.fsf@gnu.org>
References: <20170131160017.7991-1-dannym@scratchpost.org>
	<87bmula6vr.fsf@gnu.org> <20170202203629.14521773@scratchpost.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56161)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1cZh3X-0004GT-7X
	for guix-devel@gnu.org; Fri, 03 Feb 2017 11:49:52 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1cZh3S-0001v2-JQ
	for guix-devel@gnu.org; Fri, 03 Feb 2017 11:49:51 -0500
In-Reply-To: <20170202203629.14521773@scratchpost.org> (Danny Milosavljevic's
	message of "Thu, 2 Feb 2017 20:36:29 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: guix-devel@gnu.org

Danny Milosavljevic <dannym@scratchpost.org> skribis:

> Hi Ludo,
>
> On Wed, 01 Feb 2017 23:22:32 +0100
> ludo@gnu.org (Ludovic Court=C3=A8s) wrote:
>
>> Is it necessary?  It might be a case where picking whatever=E2=80=99s in=
 $PATH
>> (=E2=80=9Clate binding=E2=80=9D) is good enough; for instance, =E2=80=98=
gcc=E2=80=99 picks =E2=80=98ld=E2=80=99 from
>> $PATH, and that=E2=80=99s fine.
>
> I don't know. What's the policy for pkg-config in general?
>
> I did it that way now because
>
> (1) pkg-config is not a native-input of anything D - so if the user didn'=
t install pkg-config into his profile by chance, the build of some D packag=
es will fail.
> (2) pkg-config itself is very seldomly updated so it doesn't matter if du=
b pins it to one specific version - that would even be what I would expect =
to happen.
>
> I'm fine with adding it someway else (especially if it's the same way it'=
s usually added).
>
> So either
>
> (a) dub needs it as input (like this patch would do) or
> (b) every D package needs it as native-input (maybe the build system woul=
d auto-add it as native-input to every D package - like it does add ldc and=
 dub)
>
> - otherwise it will break.

I think =E2=80=98dub-build-system=E2=80=99 could add it as an implicit inpu=
t, much like
=E2=80=98gnu-build-system=E2=80=99 adds binutils as an implicit input.

Or we could simply let people add pkg-config as an input when it=E2=80=99s
necessary, just like we do for =E2=80=98gnu-build-system=E2=80=99 packages.

Thoughts?

Ludo=E2=80=99.