From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christopher Allan Webber Subject: Re: On merging the npm importer Date: Wed, 29 Mar 2017 12:39:35 -0500 Message-ID: <87vaqsaso8.fsf@dustycloud.org> References: <87zig5mj5c.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:35131) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ctHZP-0004Mc-5p for guix-devel@gnu.org; Wed, 29 Mar 2017 13:39:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ctHZN-0000Mm-Vi for guix-devel@gnu.org; Wed, 29 Mar 2017 13:39:43 -0400 Received: from dustycloud.org ([2600:3c02::f03c:91ff:feae:cb51]:32986) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ctHZN-0000M1-OG for guix-devel@gnu.org; Wed, 29 Mar 2017 13:39:41 -0400 In-reply-to: <87zig5mj5c.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Jan Nieuwenhuizen Cc: guix-devel@gnu.org Jan Nieuwenhuizen writes: > Hi, Hi Jan! > We have a working importer for npm packages written by Jelle that I have > been using for about half a year. It can use some improvements and > that's why I think we should merge it. > > Have alook at my npm branch here, rebased on master > > https://gitlab.com/janneke/guix Would like to review soon, though I'll say that I think unless there are serious problems, we should probably merge it. Avoiding bitrot is prety important, and at the very least I don't think it will hurt to have it merged. > I added a patch with several fixes for the importer and and build > system. So far, so good. > > There's a problem however with the --recursive option and the build > system. To quote Jelle[1] > > To start of with something that did not work out as well as I had > hoped, getting a popular build system (e.g. Gulp, Grunt, Broccoli and > others) packaged. As mentioned in my earlier mails, the list of > transitive dependencies of any of these suffer from at least the > following: > > - It is a list with more than 4000 packages on it > - It is a list with at some point the package itself on it > > Most nontrivial npm packages use a build system, and all build systems > have circular development dependencies. Not all development > dependencies are always required to build a package, but some certainly > are nd there's no way to tell which is which, afaik. > > That's why I added a --binary option to the importer: it will not > try to use the build system and instead mimick `what npm does.' This > does provide, however, an amazing reproducibility feature to the > dependency woes that npm hackers are familar with. > > I suggest to not add any npm package to Guix that is the result of using > the --binary option and to build a base of full-source/sanitized npm > packages. Cool... makes sense to me to have this as something we don't use for Guix packages, but which might make Guix more useful for people who have to use npm in the awkward "real world" that is the current state of npm. > Greetings, janneke > > [1] https://lists.gnu.org/archive/html/guix-devel/2016-08/msg01567.html