unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: guix-devel@gnu.org, Rutger Helling <rhelling@mykolab.com>
Subject: Re: 02/02: gnu: wine64-staging: Copy missing man file.
Date: Tue, 02 Jan 2018 23:25:48 +0100	[thread overview]
Message-ID: <87vagjx5hv.fsf@gnu.org> (raw)
In-Reply-To: <20180102104045.DDA98206A2@vcs0.savannah.gnu.org> (Rutger Helling's message of "Tue, 2 Jan 2018 05:40:45 -0500 (EST)")

Hi,

This is your friendly nitpicking bot!  ;-)

rhelling@mykolab.com (Rutger Helling) skribis:

>                                         "/bin/wine-preloader") (string-append
>                                         (assoc-ref %outputs "out")
>                                         "/bin/wine-preloader"))
> +             ;; Copy the missing man file for the wine binary from wine-staging.
> +             (system (string-append "gunzip < " (string-append (assoc-ref
> +                                    %build-inputs "wine-staging")
> +                                    "/share/man/man1/wine.1.gz") "> "
> +                                    (string-append (assoc-ref %outputs "out")
> +                                    "/share/man/man1/wine.1")))
>               #t))

The indentation of the nested ‘string-append’ calls is misleading here
(and the nested calls are unnecessary because ‘string-append’ is n-ary.)

Also, I think it’s OK to leave the file compressed (we have a man page
compression phase anyway.)

Thanks!

Ludo’.

       reply	other threads:[~2018-01-02 22:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20180102104042.1024.9064@vcs0.savannah.gnu.org>
     [not found] ` <20180102104045.DDA98206A2@vcs0.savannah.gnu.org>
2018-01-02 22:25   ` Ludovic Courtès [this message]
2018-01-03 10:13     ` 02/02: gnu: wine64-staging: Copy missing man file Rutger Helling

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vagjx5hv.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=guix-devel@gnu.org \
    --cc=rhelling@mykolab.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).