From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH] guix-daemon: Add option to disable garbage collection. Date: Thu, 19 Apr 2018 17:26:36 +0200 Message-ID: <87vacni5eb.fsf@gnu.org> References: <87a7uklht1.fsf@gnu.org> <87po3g9znv.fsf@gnu.org> <87vad8o0av.fsf@gnu.org> <874lkijhts.fsf@gnu.org> <87sh7rmuot.fsf@inria.fr> <871sfbcs5t.fsf@gnu.org> <87tvs7jlsc.fsf@inria.fr> <87vacnb52y.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:37807) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f9BSP-0005cM-Pn for guix-devel@gnu.org; Thu, 19 Apr 2018 11:26:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f9BSL-0002e0-7K for guix-devel@gnu.org; Thu, 19 Apr 2018 11:26:45 -0400 In-Reply-To: <87vacnb52y.fsf@gnu.org> (Roel Janssen's message of "Thu, 19 Apr 2018 17:15:28 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Roel Janssen Cc: guix-devel Heya, Roel Janssen skribis: > From fcbe7ebb3d205cf7310700e62b78b9aafd94f76f Mon Sep 17 00:00:00 2001 > From: Roel Janssen > Date: Thu, 19 Apr 2018 17:11:30 +0200 > Subject: [PATCH] guix-daemon: Disable garbage collection for remote > connections. > > * nix/nix-daemon/nix-daemon.cc (isRemoteConnection): New variable. > (performOp): For wopCollectGarbage, throw an error when isRemoteConnect= ion > is set. > (acceptConnection): Set isRemoteConnection when connection is not AF_UN= IX. > * tests/guix-daemon.sh: Add a test for the new behavior. LGTM, thanks for the quick reply! Ludo=E2=80=99.