From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christopher Baines Subject: Re: 01/01: python: Honor '--cores=...' in tests. Date: Fri, 14 Dec 2018 15:50:37 +0000 Message-ID: <87va3ww1iq.fsf@cbaines.net> References: <20181117064344.29159.44615@vcs0.savannah.gnu.org> <20181117064345.133A42043C@vcs0.savannah.gnu.org> <87y38sw2ey.fsf@cbaines.net> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:37243) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gXpje-00054q-LK for guix-devel@gnu.org; Fri, 14 Dec 2018 10:50:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gXpjb-0002oc-EP for guix-devel@gnu.org; Fri, 14 Dec 2018 10:50:42 -0500 Received: from mira.cbaines.net ([2a01:7e00::f03c:91ff:fe69:8da9]:58904) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gXpjb-0002n9-7J for guix-devel@gnu.org; Fri, 14 Dec 2018 10:50:39 -0500 In-reply-to: <87y38sw2ey.fsf@cbaines.net> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Eric Bavier Cc: guix-devel@gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Christopher Baines writes: > Eric Bavier writes: > >> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm >> index 2b6a064..46ce0dd 100644 >> --- a/gnu/packages/python.scm >> +++ b/gnu/packages/python.scm >> @@ -190,6 +190,9 @@ >> "--enable-unicode=3Ducs4" >> (string-append "LDFLAGS=3D-Wl,-rpath=3D" >> (assoc-ref %outputs "out") "/lib")) >> + ;; With no -j argument tests use all available cpus, so provide = one. >> + #:make-flags >> + (list (format #f "EXTRATESTOPTS=3D-j~d" (parallel-job-count))) >>=20=20 >> #:modules ((ice-9 ftw) (ice-9 match) >> (guix build utils) (guix build gnu-build-system)) > > Hi Eric, > > I'm having trouble building the python2 package on core-updates (which > was renamed from core-updates-next), and I think it relates to this > change. > > This is roughly the issue I'm seeing: > > LD_LIBRARY_PATH=3D/tmp/guix-build-python2-2.7.15.drv-0/Python-2.7.15 ./= python -Wd -3 -E -tt ./Lib/test/regrtest.py -l -j12 > > -l and -j don't go together! > > > Since all the python packages look to inherit from python-2.7 that's > being changed here, perhaps this worked for some of them (I know you > mentioned python-minimal in one message), but not all of them, or at > least python2? Just got around to testing this, moving this change to python-3.7, from python-2.7 fixes the python-2.7 build for me, but I haven't checked how that affects how many cores are actually used when running the tests. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlwT0U1fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XeS0BAAhUAMZ6Jo6YuU+zAXQ3y2ru4amww+dtoKk842qDzBKXA6eYgzuk8hcfX3 ePLZHePWQzdlOrZVv9ZUtr8Qx7WNF1YmvhuDUBGSAIvj31n9wyhY+BDs/mIc11zV VsEPkvZEhui8qytXg/XlPpzcBU1OrsgU9LZhIGRkMFRUK6FR5qnCDflchREJx+Vr N5FoUB9UlxKOVUiKOSDFGGTdwwFeVelvvJQ4J3RXhQF5IPhwjK7YJAqfJda+H/zq G6JV56p08Pv1530tpVrimESbmDxh5pXb2rVaSF1oA0+2FtrT+GwU6YHwR/orB4gf jZqx1MZL0i8X8UQe3CrSf+aXQ+taGnz4ZZdG68KSkGQBxi1LHm4pwcmBWowx085s oOqok+nWOrUyYbFn73G5tSIqOIhnPwAX5+kpk2BqJvgf/N+FXkEEqmNFjMu/IsQz R8Y6e9ruHJ8m5psFMy7dCD2mTHmPAw9aqfBonI7i2tSlvtp+Tt/TJ3IuQ0pSN1J/ XiDUwMWLNk5KMQoWZv5K/r1i6rwM8yYCfhbMW7s8GYT133mKGHMxTWpxpqhbBBSO PLNJ0sY+GRtnbLcnRTtb2jp2mXV7CnMGDCSjiCtsK0aelTnNT6jw7cGnmSj4C1zH 9R/drqCX0tfOeFnzveq7QEQ2sHKa2ka+5LWqUnM7+imoDpj6bwQ= =tUMd -----END PGP SIGNATURE----- --=-=-=--