Re: 01/01: python: Honor '--cores=...' in tests.

[Christopher Baines <mail@cbaines.net>]

[-- Attachment #1: Type: text/plain, Size: 1618 bytes --]


Christopher Baines <mail@cbaines.net> writes:

> Eric Bavier <ericbavier@centurylink.net> writes:
>
>> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
>> index 2b6a064..46ce0dd 100644
>> --- a/gnu/packages/python.scm
>> +++ b/gnu/packages/python.scm
>> @@ -190,6 +190,9 @@
>>               "--enable-unicode=ucs4"
>>               (string-append "LDFLAGS=-Wl,-rpath="
>>                              (assoc-ref %outputs "out") "/lib"))
>> +       ;; With no -j argument tests use all available cpus, so provide one.
>> +       #:make-flags
>> +       (list (format #f "EXTRATESTOPTS=-j~d" (parallel-job-count)))
>>  
>>          #:modules ((ice-9 ftw) (ice-9 match)
>>                     (guix build utils) (guix build gnu-build-system))
>
> Hi Eric,
>
> I'm having trouble building the python2 package on core-updates (which
> was renamed from core-updates-next), and I think it relates to this
> change.
>
> This is roughly the issue I'm seeing:
>
>   LD_LIBRARY_PATH=/tmp/guix-build-python2-2.7.15.drv-0/Python-2.7.15 ./python -Wd -3 -E -tt  ./Lib/test/regrtest.py -l -j12
>
>   -l and -j don't go together!
>
>
> Since all the python packages look to inherit from python-2.7 that's
> being changed here, perhaps this worked for some of them (I know you
> mentioned python-minimal in one message), but not all of them, or at
> least python2?

Just got around to testing this, moving this change to python-3.7, from
python-2.7 fixes the python-2.7 build for me, but I haven't checked
how that affects how many cores are actually used when running the tests.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 962 bytes --]