unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Mark H Weaver <mhw@netris.org>
To: Efraim Flashner <efraim@flashner.co.il>
Cc: guix-devel@gnu.org
Subject: Re: Help needed packaging rust-cbindgen, a dependency of IceCat 68
Date: Tue, 22 Oct 2019 15:56:42 -0400	[thread overview]
Message-ID: <87v9sgzh7u.fsf@netris.org> (raw)
In-Reply-To: <87zhhszhuv.fsf@netris.org> (Mark H. Weaver's message of "Tue, 22 Oct 2019 15:42:53 -0400")

Hi Efraim,

Mark H Weaver <mhw@netris.org> writes:

> Efraim Flashner <efraim@flashner.co.il> writes:
>> Here's what I have for rust-cbindgen based more-or-less on my
>> re-imagining of the cargo-build-system and the rust inputs.
>
> Thank you very much for this!  Notably, I see that every package in your
> source has a proper 'license' field, and that there are *far* fewer
> dependencies here than 'guix import crate -r cbindgen' pulled in.
>
> What's the feasibility of turning this file into a set of commits that
> could be applied to 'master' in the next day or two?  If that could be
> done, it would be tremendously helpful.  I think it's okay if these
> "re-imagined" Rust packages are all 'hidden' for now and put in a
> separate module, to avoid breaking anything else or interfering with the
> packages in crates.io.
>
> Would you like to do it?

I looked again, and I see that you _already_ marked all of the packages
'hidden' except for 'rust-cbindgen' itself.  Perfect!  Somehow I managed
to miss that on my first perusal of the code.

The only additional suggestion I'd make is to change 'define-public' to
'define' for all of these packages except for 'rust-cbindgen', to avoid
possible conflicts in modules that import both 'cbindgen.scm' and
'crates-io.scm'.

How about simply putting this file in (gnu packages rust-cbindgen) for
now, with the file header comment changed to match other files in Guix,
and with the trailing 'rust-cbindgen' at the bottom removed.

Would you like to do this?  If not, I could do it.

Thanks again!  This is a great help and an enormous relief to me.

     Mark

  reply	other threads:[~2019-10-22 19:57 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-22  6:23 Help needed packaging rust-cbindgen, a dependency of IceCat 68 Mark H Weaver
2019-10-22  9:00 ` John Soo
2019-10-22  9:10   ` Mark H Weaver
2019-10-22  9:23     ` Mark H Weaver
2019-10-22  9:19 ` Jonathan Brielmaier
2019-10-22  9:33   ` Efraim Flashner
2019-10-22 14:17 ` Ludovic Courtès
2019-10-22 19:24   ` Mark H Weaver
2019-10-23 17:53   ` Marius Bakke
2019-10-22 18:54 ` Efraim Flashner
2019-10-22 19:42   ` Mark H Weaver
2019-10-22 19:56     ` Mark H Weaver [this message]
2019-10-22 20:06       ` Efraim Flashner
2019-10-23  7:50         ` Efraim Flashner
2019-10-23 10:33           ` Mark H Weaver
2019-10-26 18:36 ` Chris Marusich
2019-10-27 17:00   ` Mark H Weaver
2019-10-30  5:52   ` Mark H Weaver

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v9sgzh7u.fsf@netris.org \
    --to=mhw@netris.org \
    --cc=efraim@flashner.co.il \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).