From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id YAaRA3VLq17ANQAA0tVLHw (envelope-from ) for ; Thu, 30 Apr 2020 22:04:37 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id GPckNX1Lq17adgAA1q6Kng (envelope-from ) for ; Thu, 30 Apr 2020 22:04:45 +0000 Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:470:142::17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 08C68941750 for ; Thu, 30 Apr 2020 22:04:45 +0000 (UTC) Received: from localhost ([::1]:54636 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jUHIT-00085v-1N for larch@yhetil.org; Thu, 30 Apr 2020 18:04:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51306) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jUHHi-00085h-1H for guix-devel@gnu.org; Thu, 30 Apr 2020 18:04:00 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:59438) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jUHHe-0008De-D0 for guix-devel@gnu.org; Thu, 30 Apr 2020 18:03:56 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=35730 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jUHHd-0002l1-N1 for guix-devel@gnu.org; Thu, 30 Apr 2020 18:03:54 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: guix-devel@gnu.org Subject: Re: 13/36: services: Add hurd-console-service-type. References: <20200427101927.7020.76060@vcs0.savannah.gnu.org> <20200427101946.414C420A5E@vcs0.savannah.gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 12 =?utf-8?Q?Flor=C3=A9al?= an 228 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Fri, 01 May 2020 00:03:51 +0200 In-Reply-To: <20200427101946.414C420A5E@vcs0.savannah.gnu.org> (guix-commits@gnu.org's message of "Mon, 27 Apr 2020 06:19:46 -0400 (EDT)") Message-ID: <87v9lgljg8.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Scanner: scn0 X-Spam-Score: -1.01 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 2001:470:142::17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Scan-Result: default: False [-1.01 / 13.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; GENERIC_REPUTATION(0.00)[-0.49472554602398]; DWL_DNSWL_FAIL(0.00)[2001:470:142::17:server fail]; R_SPF_ALLOW(-0.20)[+ip6:2001:470:142::/48:c]; IP_REPUTATION_HAM(0.00)[asn: 22989(0.17), country: US(-0.00), ip: 2001:470:142::17(-0.49)]; TO_DN_NONE(0.00)[]; MX_GOOD(-0.50)[cached: eggs.gnu.org]; MAILLIST(-0.20)[mailman]; FORGED_RECIPIENTS_MAILLIST(0.00)[]; RCVD_IN_DNSWL_FAIL(0.00)[2001:470:142::17:server fail]; RCVD_TLS_LAST(0.00)[]; R_DKIM_NA(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; TAGGED_FROM(0.00)[larch=yhetil.org]; ASN(0.00)[asn:22989, ipnet:2001:470:142::/48, country:US]; ARC_NA(0.00)[]; RCVD_COUNT_FIVE(0.00)[5]; FROM_NEQ_ENVFROM(0.00)[ludo@gnu.org,guix-devel-bounces@gnu.org]; FROM_HAS_DN(0.00)[]; TO_DOM_EQ_FROM_DOM(0.00)[]; URIBL_BLOCKED(0.00)[gnu.org:email]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[gnu.org]; HAS_LIST_UNSUB(-0.01)[]; RCPT_COUNT_ONE(0.00)[1]; MIME_TRACE(0.00)[0:+]; FORGED_SENDER_MAILLIST(0.00)[] X-TUID: dCCYnCksK5We guix-commits@gnu.org skribis: > commit d7a217e67dcd3b14402d746f4428db8545ce83f2 > Author: Jan (janneke) Nieuwenhuizen > AuthorDate: Mon Apr 13 10:13:05 2020 +0200 > > services: Add hurd-console-service-type. >=20=20=20=20=20 > * gnu/services/hurd.scm (): New variable. > (hurd-console-shepherd-service, hurd-console-service-type): New funct= ion. > (hurd-service->shepherd-service): Add entry. Now for the exciting stuff, neat! > - #:export (hurd-service->shepherd-service)) > + #:export (hurd-console-service-type > + hurd-service->shepherd-service)) >=20=20 > ;;; Commentary: > ;;; > @@ -38,9 +39,51 @@ > (define (hurd-service->shepherd-service service) > (let ((config (service-value service))) > (match config > + (($ ) (hurd-console-shepherd-service c= onfig)) > (_ '())))) Hmm do we really need this =E2=80=98hurd-service->shepherd-service=E2=80=99= procedure? I haven=E2=80=99t read the rest, but it seems surprising at first sight. > + (list (shepherd-service > + (documentation "Hurd console.") =E2=80=9CRun the Hurd=E2=80=99s VGA console client.=E2=80=9D > + (provision '(console)) > + (requirement '()) Should be '(user-processes) I think. > + (start #~(lambda _ (fork+exec-command #$console-command) #t)) Rather #~(make-forkexec-constructor #$console-command). > +(define hurd-console-service-type > + (service-type > + (name 'console) > + (description > + "Run a hurd console, @command{console}.") Maybe =E2=80=9CRun the Hurd console client.=E2=80=9D > + (compose concatenate) > + (extend first-of-two) I don=E2=80=99t think we need these two fields since this service is not me= ant to be extensible. > + (default-value (hurd-console-configuration)))) Please add a =E2=80=98description=E2=80=99 too! Also, normally we document every new service type in the manual, but maybe we can delay it here so that you can unleash your hack powers in the meantime. :-) Thanks, Ludo=E2=80=99.