From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id YEGIMAeRs17MDgAA0tVLHw (envelope-from ) for ; Thu, 07 May 2020 04:39:35 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id eJqrMhORs15nawAAbx9fmQ (envelope-from ) for ; Thu, 07 May 2020 04:39:47 +0000 Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:470:142::17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id EC0E7940FD9 for ; Thu, 7 May 2020 04:39:45 +0000 (UTC) Received: from localhost ([::1]:57552 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jWYK2-0002b4-Jy for larch@yhetil.org; Thu, 07 May 2020 00:39:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56914) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jWYJu-0002ah-Ck for guix-devel@gnu.org; Thu, 07 May 2020 00:39:38 -0400 Received: from mail-qt1-x832.google.com ([2607:f8b0:4864:20::832]:37964) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jWYJr-0004yv-OF for guix-devel@gnu.org; Thu, 07 May 2020 00:39:38 -0400 Received: by mail-qt1-x832.google.com with SMTP id i68so3674052qtb.5 for ; Wed, 06 May 2020 21:39:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=42uNwYjNWvR2Bq/jfVul9mw6yju0Rtc4+ovzLgslfdw=; b=PgrtU2MBtjInKNCtFPO7I/8y+02XTjPvP2mR1F5Q3YgK0+KtFmA7C/SkMrGGyra81T X348HDB6bzNgj8dwombFdfgJHoyAORSr3F9LHRS/KU7GDfc0mx67zQAju7IKSAA5Knsj tx6a8U/Ejy/MxmlLaBm4gnz6p6Xv/I9/joekPj5wFl7oe3NcD/mPQt4ocxYXt++KCAeH tcraoc+GPUmvFCGLxreQ2jurHFh0bhuyFE2pZNXRHYInZUBwkNZUBd68Wy53LPPsYmgH LAdprQACHug7xjfnrfl/ThwoX4SXzuYeDVnPOxSLmfefPvqvgFy4rPjUK4i8KBH4GGx5 EGSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=42uNwYjNWvR2Bq/jfVul9mw6yju0Rtc4+ovzLgslfdw=; b=c3RxZdHpyxbB3Hx1WVqieIn8icJQHKSirvrRqDWvX0manwLQNQOsunNuVkGqcYrGL+ +yOELfBPOmH+VwT8ivokYDnDHBD79qe3lyyN7ufpgygmuHJG9cnAE3PvO86E2ejzNYgE VkKm39uh9yT0XWEuRd/W9lYz//eDFt+JN0Yi/XAcGFgqC/u7KwJBpSFSYJ87l4vtYeO0 PKQvx0CpK/bIbUNV31pPuzvt7GX2vXNT2I0TzowAzrp1Tg4nnj18fHif60LASnE0m2ro p8Enyq7AJNgAaknNO3nhn53HsDmy6kEhdNR54oDXWSQv4aQh6wWzXbXMPT1pPVYECosw 78Uw== X-Gm-Message-State: AGi0PuYUU9y/SgR4nBHeui6eysBxW/NrwFiEMSJR26v4nrQbp2hLwDNh FsJRu9lCuF8KtzIbu6N0+Vry5oS2 X-Google-Smtp-Source: APiQypKKU6oGmu8Z3IuTlOd/dnu0+/DH6CME6nyAa8mKxdtJkpnQoHNqRJh6qH5Cq+RxbA/ao3M+OA== X-Received: by 2002:ac8:34b2:: with SMTP id w47mr12221968qtb.271.1588826374309; Wed, 06 May 2020 21:39:34 -0700 (PDT) Received: from hurd (dsl-236-123-224.b2b2c.ca. [207.236.123.224]) by smtp.gmail.com with ESMTPSA id t67sm3381572qka.17.2020.05.06.21.39.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 May 2020 21:39:33 -0700 (PDT) From: Maxim Cournoyer To: =?utf-8?Q?Nicol=C3=B2?= Balzarotti Subject: Re: Inkscape 1.0 upgrade References: <87y2q420hu.fsf@guixSD.i-did-not-set--mail-host-address--so-tickle-me> Date: Thu, 07 May 2020 00:39:24 -0400 In-Reply-To: <87y2q420hu.fsf@guixSD.i-did-not-set--mail-host-address--so-tickle-me> (=?utf-8?Q?=22Nicol=C3=B2?= Balzarotti"'s message of "Wed, 06 May 2020 23:54:05 +0200") Message-ID: <87v9l8z7cz.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::832; envelope-from=maxim.cournoyer@gmail.com; helo=mail-qt1-x832.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "guix-devel@gnu.org" Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Scanner: scn0 X-Spam-Score: 0.09 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=gmail.com header.s=20161025 header.b=PgrtU2MB; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 2001:470:142::17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Scan-Result: default: False [0.09 / 13.00]; TO_DN_EQ_ADDR_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; GENERIC_REPUTATION(0.00)[-0.4975954088279]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2001:470:142::/48:c]; R_DKIM_REJECT(1.00)[gmail.com:s=20161025]; DWL_DNSWL_BLOCKED(0.00)[2001:470:142::17:from]; FREEMAIL_FROM(0.00)[gmail.com]; IP_REPUTATION_HAM(0.00)[asn: 22989(0.11), country: US(-0.00), ip: 2001:470:142::17(-0.50)]; DKIM_TRACE(0.00)[gmail.com:-]; RCPT_COUNT_TWO(0.00)[2]; MX_GOOD(-0.50)[cached: eggs.gnu.org]; MAILLIST(-0.20)[mailman]; FREEMAIL_TO(0.00)[gmail.com]; RCVD_IN_DNSWL_FAIL(0.00)[2001:470:142::17:server fail]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:22989, ipnet:2001:470:142::/48, country:US]; MID_RHS_MATCH_FROM(0.00)[]; TAGGED_FROM(0.00)[larch=yhetil.org]; ARC_NA(0.00)[]; RCVD_COUNT_FIVE(0.00)[6]; FROM_NEQ_ENVFROM(0.00)[maximcournoyer@gmail.com,guix-devel-bounces@gnu.org]; FROM_HAS_DN(0.00)[]; URIBL_BLOCKED(0.00)[elenq.tech:email,gitlab.com:url,gnu.org:url,inkscape.org:url,autogen.sh:url]; FORGED_RECIPIENTS_MAILLIST(0.00)[]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[guix-devel@gnu.org]; HAS_LIST_UNSUB(-0.01)[]; FORGED_SENDER_MAILLIST(0.00)[]; DMARC_POLICY_SOFTFAIL(0.10)[gmail.com : SPF not aligned (relaxed),none] X-TUID: 5qkQyU5vK4B1 Hello! It seems we're now at least 3 people to have worked toward Inkscape 1.0 :-). I've posted a patch series adding a Inkscape 1.0 and various other dependencies at http://bugs.gnu.org/41118, if you'd like to compare. Nicol=C3=B2 Balzarotti writes: > Hi, I wanted the same. My package is working but I cannot replace the > current inkscape as there's a dependency loop, so I called it > inkscape-1.0. The loop was caused by the gtk-doc package part of gdl. I've worked around this by creating a gdl-minimal package, which doesn't include such input. > But in today's blogpost Ludo installed inkscape 1.0, so > maybe he already solved it. Here's my working definition btw, if you > want to submit it please go ahead :) He's confirmed that this was aspirational. The version seen in the derivation output is what is in master :-). > Nicol=C3=B2 > [1] https://guix.gnu.org/blog/2020/grafts-continued/ > > (define-public libgdl > (package > (name "libgdl") > (version "3.34.0") > (source (origin > (method url-fetch) > (uri (string-append "mirror://gnome/sources/gdl/" > (version-major+minor version) "/gdl-" > version ".tar.xz")) > (sha256 > (base32 > "00ldva6wg6s4wlxmisiqzyz8ihsprra7sninx2rlqk6frpq312w5")))) > (build-system gnu-build-system) > (native-inputs > `(("automake" ,automake) > ("autoconf" ,autoconf) > ("intltool" ,intltool) > ("libtool" ,libtool) > ("pkg-config" ,pkg-config) > ("gtk-doc" ,gtk-doc) > ("gtk+" ,gtk+) gtk+ should be propagated in this case, because it is marked as "Required" in the pkg-config gdl-3.0.pc file. > ("which" ,which))) > (inputs > `( > ("libxml2" ,libxml2) > ;; ("boost" ,boost) > )) > ;; (native-inputs > ;; `(("intltool" ,intltool) > ;; ("glib" ,glib "bin") > ;; ("perl" ,perl) > ;; ("pkg-config" ,pkg-config))) > ;; (arguments > ;; `(#:phases > ;; (modify-phases %standard-phases > ;; (add-before 'bootstrap 'disable-maintainer-mode > ;; (lambda _ > ;; (substitute* "autogen.sh" > ;; (("/bin/sh") (which "sh"))) > ;; #t)) > ;; (replace 'bootstrap > ;; (lambda _ > ;; (system* "./autogen.sh") > ;; (substitute* "./configure" > ;; (("/bin/sh") (which "sh"))) > ;; (invoke "./autogen.sh") I remember struggling with this as well, and found some neat example somewhere else in our package collection that causes the gnome-common autogen.sh to *not* run configure itself. This is done by setting NOCONFIGURE before invoking autogen.sh. > ;; #t))))) > (home-page "https://inkscape.org/") > (synopsis "Vector graphics editor") > (description "Inkscape is a vector graphics editor. What sets Inksca= pe > apart is its use of Scalable Vector Graphics (SVG), an XML-based W3C stan= dard, > as the native format.") > (license license:gpl2+))) It seems this part was not finished :-) > > (define-public inkscape-1.0 > (package > (name "inkscape") > (version "1.0") > (source (origin > (method git-fetch) > (uri (git-reference > (url "https://gitlab.com/inkscape/inkscape.git") > (commit "INKSCAPE_1_0") > (recursive? #t))) When using recursive, this usually means there are bundled libraries, which calls for a justification or FIXME comment. > ;; (patches (search-patches "inkscape-poppler-0.76.patch")) This patch is no longer needed > (sha256 > (base32 > "119j1yhjgjh49dhlxzy9xmprkgw2d8q8ypvr23wac0ppv2kklp57")))) > (build-system cmake-build-system) > (inputs > `(("aspell" ,aspell) > ("double-conversion" ,double-conversion) > ("gtkmm" ,gtkmm) > ("gtk" ,gtk+) > ("gsl" ,gsl) > ("poppler" ,poppler) > ("libpng" ,libpng) > ("libxml2" ,libxml2) > ("libxslt" ,libxslt) > ("libgc" ,libgc) > ("libgdl" ,libgdl) > ("libjpeg" ,libjpeg) I think libjpeg is deprecated in favor of libjpeg-turbo, at least in core-updates. > ("libsoup" ,libsoup) I've used libsoup-minimal here, I don't remember if there was a cycle problem otherwise. > ("libvisio" ,libvisio) > ("libwpg" ,libwpg) > ("libwpd" ,libwpd) > ("libcdr" ,libcdr) > ("freetype" ,freetype) > ("gtkspell3" ,gtkspell3) I've missed the gtkspell3, libcdr, libwpd, libwpg and libvisio optional dependencies. I'll add them, as we usually try to support as much features as we can in the Guix packages. Nice! > ("imagemagick" ,imagemagick) > ("popt" ,popt) > ("potrace" ,potrace) > ("python" ,python-3) > ("lcms" ,lcms) > ("boost" ,boost))) > (native-inputs > `(("intltool" ,intltool) > ("glib" ,glib "bin") > ("googletest" ,googletest) > ("perl" ,perl) > ("pkg-config" ,pkg-config))) > (arguments > ;; RE-enable > `(#:tests? #f Next time, please eave a comment saying why the test suite is disabled. I'= ve managed to have the test run in my series; it was a bit of a pain :-). > ;; Defaults to RelWithDebInfo > #:configure-flags '("-DCMAKE_BUILD_TYPE=3DRelease") > #:phases > (modify-phases %standard-phases > ;; (add-after 'unpack 'patch-icon-cache-generator > ;; (lambda _ > ;; (substitute* "share/icons/application/CMakeLists.txt" > ;; (("gtk-update-icon-cache") "true")) > ;; #t)) > (add-before 'configure 'dont-use-system-includes > (lambda _ > ;; Don't add redundant -isystem includes which confuses GCC7. > (substitute* "CMakeScripts/DefineDependsandFlags.cmake" > (("include_directories\\(SYSTEM") > "include_directories(")) > #t)) > (add-before 'configure 'dont-use-werror-format > (lambda _ > ;; Don't add redundant -isystem includes which confuses GCC7. > (substitute* "CMakeScripts/DefineDependsandFlags.cmake" > (("-Werror=3Dformat\"") "\"") > (("-Werror=3Dformat-security\"") "\"")) > #t))))) These two new phases are not needed when working on core-updates (which will soon be merged into master), as the CPATH problem is resolved there (we're now back to using C_INCLUDE_PATH and CPLUS_INCLUDE_PATH). > (home-page "https://inkscape.org/") > (synopsis "Vector graphics editor") > (description "Inkscape is a vector graphics editor. What sets Inksca= pe > apart is its use of Scalable Vector Graphics (SVG), an XML-based W3C stan= dard, > as the native format.") > (license license:gpl2+))) > > Ekaitz Zarraga writes: Thanks for sharing this patch! Maxim