unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Pierre Neidhardt <mail@ambrevar.xyz>
Cc: guix-devel@gnu.org,
	Katherine Cox-Buday <cox.katherine.e@gmail.com>,
	Maxim Cournoyer <maxim.cournoyer@gmail.com>
Subject: Re: Can we increase the print width/column in daemon backtraces
Date: Fri, 29 May 2020 00:07:11 +0200	[thread overview]
Message-ID: <87v9kf7lyo.fsf@gnu.org> (raw)
In-Reply-To: <87h7w1eirq.fsf@ambrevar.xyz> (Pierre Neidhardt's message of "Wed, 27 May 2020 13:09:45 +0200")

Hi,

Pierre Neidhardt <mail@ambrevar.xyz> skribis:

> Ricardo Wurmus <rekado@elephly.net> writes:
>
>> diff --git a/nix/libstore/build.cc b/nix/libstore/build.cc
>> index 29266f1dd6..94609e07f5 100644
>> --- a/nix/libstore/build.cc
>> +++ b/nix/libstore/build.cc
>> @@ -2247,6 +2247,7 @@ void DerivationGoal::runChild()
>>          Strings envStrs;
>>          foreach (Environment::const_iterator, i, env)
>>              envStrs.push_back(rewriteHashes(i->first + "=" + i->second, rewritesToTmp));
>> +	envStrs.push_back("COLUMNS=1024");
>>  
>>          /* If we are running in `build-users' mode, then switch to the
>>             user we allocated above.  Make sure that we drop all root
>
> What about merging this then?

This modifies the environment of every single build process, so no.
Environment contents are set in stone, it’s key to reproducibility.

However, what we can do is add COLUMNS to #:env-vars in
‘package-derivation’ on ‘core-updates’ and/or as the default value of
#:env-vars in ‘gexp->derivation’.

HTH!

Ludo’.


  reply	other threads:[~2020-05-28 22:07 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-15 10:36 Can we increase the print width/column in daemon backtraces Pierre Neidhardt
2019-07-15 12:47 ` Ricardo Wurmus
2019-07-15 12:56   ` Pierre Neidhardt
2019-09-17  1:58     ` Maxim Cournoyer
2019-09-17  6:46       ` Pierre Neidhardt
2020-05-20  9:02       ` Pierre Neidhardt
2020-05-21 11:14         ` Katherine Cox-Buday
2020-05-22  8:14           ` Pierre Neidhardt
2020-05-24 21:19         ` Ludovic Courtès
2020-05-25  8:39           ` Pierre Neidhardt
2020-05-25  9:54             ` Tobias Geerinckx-Rice
2020-05-25 11:51               ` Pierre Neidhardt
2020-05-25 21:28             ` Ludovic Courtès
2020-05-26  7:16               ` Pierre Neidhardt
2020-05-25 11:51           ` Pierre Neidhardt
2020-05-25 15:26             ` Marius Bakke
2020-05-26  7:17               ` Pierre Neidhardt
2020-05-26  7:50                 ` Marius Bakke
2020-05-26  8:19                   ` Pierre Neidhardt
2020-05-27 10:43                   ` Ricardo Wurmus
2020-05-27 11:09                     ` Pierre Neidhardt
2020-05-28 22:07                       ` Ludovic Courtès [this message]
2020-05-29  9:30                         ` Pierre Neidhardt
2019-07-15 12:58   ` swedebugia
2019-07-15 15:23   ` P
2019-07-15 15:40     ` Ricardo Wurmus
2019-07-15 18:38       ` Robert Vollmert
2019-07-15 20:41         ` Robert Vollmert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v9kf7lyo.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=cox.katherine.e@gmail.com \
    --cc=guix-devel@gnu.org \
    --cc=mail@ambrevar.xyz \
    --cc=maxim.cournoyer@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).