* commit 62035656ca: Add opensmtpd-filter-dkimsign.
@ 2020-09-04 9:44 Giovanni Biscuolo
2020-10-08 9:18 ` Tobias Geerinckx-Rice
0 siblings, 1 reply; 3+ messages in thread
From: Giovanni Biscuolo @ 2020-09-04 9:44 UTC (permalink / raw)
To: guix-devel, Tobias Geerinckx-Rice
[-- Attachment #1: Type: text/plain, Size: 316 bytes --]
Hello Tobias,
looking at your recent addition (cool!) I found that your commit also
upgrades nix to 2.3.7, probably by mistake.
I don't know if there is a policy in cases like this: should we revert
that commit and split in two commits?
Kudos! Gio'
--
Giovanni Biscuolo
Xelera IT Infrastructures
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: commit 62035656ca: Add opensmtpd-filter-dkimsign.
2020-09-04 9:44 commit 62035656ca: Add opensmtpd-filter-dkimsign Giovanni Biscuolo
@ 2020-10-08 9:18 ` Tobias Geerinckx-Rice
2020-10-08 11:28 ` Giovanni Biscuolo
0 siblings, 1 reply; 3+ messages in thread
From: Tobias Geerinckx-Rice @ 2020-10-08 9:18 UTC (permalink / raw)
To: Giovanni Biscuolo; +Cc: guix-devel
[-- Attachment #1: Type: text/plain, Size: 508 bytes --]
Hi Gio',
Somehow I missed this message. Sorry about that.
Giovanni Biscuolo 写道：
> looking at your recent addition (cool!) I found that your commit
> also
> upgrades nix to 2.3.7, probably by mistake.
Yup.
> I don't know if there is a policy in cases like this: should we
> revert
> that commit and split in two commits?
Nope. It shouldn't happen, of course, but IMO once it's done it's
done (assuming it didn't break Nix, of course).
Thanks for paying attention!
T G-R
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: commit 62035656ca: Add opensmtpd-filter-dkimsign.
2020-10-08 9:18 ` Tobias Geerinckx-Rice
@ 2020-10-08 11:28 ` Giovanni Biscuolo
0 siblings, 0 replies; 3+ messages in thread
From: Giovanni Biscuolo @ 2020-10-08 11:28 UTC (permalink / raw)
To: Tobias Geerinckx-Rice; +Cc: guix-devel
[-- Attachment #1: Type: text/plain, Size: 553 bytes --]
Hi Tobias,
Tobias Geerinckx-Rice <me@tobias.gr> writes:
> Hi Gio',
>
> Somehow I missed this message. Sorry about that.
Non prob!
> Giovanni Biscuolo 写道：
[...]
>> I don't know if there is a policy in cases like this: should we
>> revert that commit and split in two commits?
>
> Nope. It shouldn't happen, of course, but IMO once it's done it's
> done (assuming it didn't break Nix, of course).
OK understood, thank you for your feedback.
Ciao, Gio'
[...]
--
Giovanni Biscuolo
Xelera IT Infrastructures
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 849 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-10-08 11:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-04 9:44 commit 62035656ca: Add opensmtpd-filter-dkimsign Giovanni Biscuolo
2020-10-08 9:18 ` Tobias Geerinckx-Rice
2020-10-08 11:28 ` Giovanni Biscuolo
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).