From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id gHicFXTJlV9FUwAA0tVLHw (envelope-from ) for ; Sun, 25 Oct 2020 18:52:36 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id MDV1EXTJlV/CKQAAbx9fmQ (envelope-from ) for ; Sun, 25 Oct 2020 18:52:36 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D549D9404CE for ; Sun, 25 Oct 2020 18:52:35 +0000 (UTC) Received: from localhost ([::1]:58072 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kWl86-0006VG-R4 for larch@yhetil.org; Sun, 25 Oct 2020 14:52:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54024) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kWl7t-0006Us-OG for guix-devel@gnu.org; Sun, 25 Oct 2020 14:52:21 -0400 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:34343) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kWl7r-0001HY-7I for guix-devel@gnu.org; Sun, 25 Oct 2020 14:52:21 -0400 X-Originating-IP: 91.165.152.159 Received: from mimimi (91-165-152-159.subs.proxad.net [91.165.152.159]) (Authenticated sender: mail@ambrevar.xyz) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 9A0FEFF807; Sun, 25 Oct 2020 18:52:14 +0000 (UTC) From: Pierre Neidhardt To: Maxim Cournoyer , guix-devel@gnu.org Subject: Re: [PATCH] .dir-locals.el: Automatically set the GEISER-GUILE-LOAD-PATH variable. In-Reply-To: <20201025184228.2460-1-maxim.cournoyer@gmail.com> References: <87tuuixjno.fsf@gmail.com> <20201025184228.2460-1-maxim.cournoyer@gmail.com> Date: Sun, 25 Oct 2020 19:52:13 +0100 Message-ID: <87v9ey16le.fsf@ambrevar.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Received-SPF: pass client-ip=217.70.183.199; envelope-from=mail@ambrevar.xyz; helo=relay9-d.mail.gandi.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/25 14:27:12 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: 6 X-Spam_score: 0.6 X-Spam_bar: / X-Spam_report: (0.6 / 5.0 requ) BAYES_00=-1.9, FROM_SUSPICIOUS_NTLD=0.5, PDS_OTHER_BAD_TLD=1.999, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Maxim Cournoyer Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Spam-Score: -0.61 X-TUID: FfqxYbPNps3o --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Maxim Cournoyer writes: > + (clean-geiser-guile-load-path > + (seq-remove (lambda (x) > + (string-match "/guix" x)) > + geiser-guile-load-path))) I suggest making "/guix" a let-bound variable and add a comment explaining that channel maintainers need to change it. That said, why do we need to clean the load path? Can't we just leave the other paths? What if the user actually wants the other elements? =2D-=20 Pierre Neidhardt https://ambrevar.xyz/ --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQFGBAEBCAAwFiEEUPM+LlsMPZAEJKvom9z0l6S7zH8FAl+VyV0SHG1haWxAYW1i cmV2YXIueHl6AAoJEJvc9Jeku8x/IE8H/RMpBT3Aa3Bg7gGHQjUJLncmvtClhJqf B4fIcqOhAP63C7OGCBV9eFi34pFIO49alDDu8HnHZBwo+Y4RqnIQ5xzsMLuYRee6 //49R1tHiyDBqzQMsKKfxmXqmSk6LMzIzIWykcM+oKCO5+RAEGMS4S1yirTwOylt GaKC50aiFsFVFzzcUhVrUK1GVGKY13b0bfaaEQC8mKDvGsnf0Uk1odZZDK7xIkXK qw2cmBAG0LN4oZqcJGA47CFB9VAOD4YKSerP0YtET7kiToIgA0EgT5RIqiHtN3AE J32Um2PBcFxyauWiY7FyjHdWafkGs9pj/LSgp/zWEAZqJiVSADJpgr0= =wFvX -----END PGP SIGNATURE----- --=-=-=--