From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id qIwMI/iw6WBsXAEAgWs5BA (envelope-from ) for ; Sat, 10 Jul 2021 16:38:48 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 0Ld8Hviw6WBWZwAAbx9fmQ (envelope-from ) for ; Sat, 10 Jul 2021 14:38:48 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id EA8121858B for ; Sat, 10 Jul 2021 16:38:47 +0200 (CEST) Received: from localhost ([::1]:34492 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m2E7z-0004aQ-3w for larch@yhetil.org; Sat, 10 Jul 2021 10:38:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51978) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m2E7p-0004Yp-5D for guix-devel@gnu.org; Sat, 10 Jul 2021 10:38:37 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:34630) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m2E7n-0001rZ-PY; Sat, 10 Jul 2021 10:38:35 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=42898 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m2E7i-0004tg-Ku; Sat, 10 Jul 2021 10:38:35 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Gabriel Wicki Subject: Re: Removing package input labels: last call! References: <87h7hgssb2.fsf@inria.fr> <20210707122928.6s34jblnx5zhvd5f@knurd> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 22 Messidor an 229 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sat, 10 Jul 2021 16:38:29 +0200 In-Reply-To: <20210707122928.6s34jblnx5zhvd5f@knurd> (Gabriel Wicki's message of "Wed, 7 Jul 2021 14:29:28 +0200") Message-ID: <87v95ib5ei.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel@gnu.org Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1625927928; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=k5F3iMJk5qdUNDUZuRzkxf9ZRGVNRtqv+6EDpIlREM4=; b=tJr9U7Hjz+vz/8QolCZfNrSEIQscAczN/WJj13oiNHjS72d0LjtxkJo//b30X7oCa3HKVR zzwOPdeP8ndAhnSZF5hKuS1lZW1/+Q/JNTdwrGMLT7pKQdn7y76FzU4A4iMD9Uk39Z15wA zQ1Ocr7v2woeW3RUF/gSEeVA1xzfWl0dcqS8+bhqb6Kn1mBatLBJ+H4qlBvNzkb7nPi5MU uPHFA/sSDKMNNpto4KEZw9wHfAENacayQ1WBhTMFrehtMubRZ4MWdMU/pzYLta1E+e5Tfa WWy8KRzr7PJxmrYSm6cuAtlwgHD7+WwQymC1470h6D31flwRUxyaWOQohCyxWQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1625927928; a=rsa-sha256; cv=none; b=BdaFceLRgja9q+6RB0UOKIclXixDCt+ZWBYvXBfRpOAyzARa4+YMvE/UxtnHGuPn5zIYUD 4tlxm6RKofpm3pNXVpm824z+sZXMXjMTzHTrerrrFkoB0epLHv0OHqE1IVD8iHB0NNh8+e W7+pBassq6DgxhkSuK5j8RiLEEi596rNzh7tRfiycDlcQW5T+E3sOEAY0F8yYQtg65oMAG V0WR4aeDpOdP8bHlIYV/DISBNJFHI8kHVVli9B66muIyKz3ohQNKZYvcj0nkJZCUC+MeFX spMpULYXaWcCTy9xWyIDITwz+Yq8Dk+14kAZyLUNWHO/AndN8Rbkza6NxT+msA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Spam-Score: -2.90 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: EA8121858B X-Spam-Score: -2.90 X-Migadu-Scanner: scn0.migadu.com X-TUID: MiMuHRKq4L2D Hi Gabriel, Gabriel Wicki skribis: > - Since not all the inputs *have* to be converted to the new format: > is this more some kind of syntactic sugar and less of a "we really > want this to be the new standard" kind of improvement? > Or is the goal to replace *all* input lists with the new style? The goal is to replace all input lists with the new style. We know it=E2=80=99ll take time, but hopefully automation will reduce that. > - Regarding the speed of the transition: do I understand correctly that > the script should be able to convert the vast majority of packages > and that afterwards maybe other definitions will/might/could be > translated by hand? Yes. =E2=80=98guix style=E2=80=99 can translate =E2=80=9Csimple=E2=80=9D c= ases, and it has three strategies now (via the =E2=80=98--input-simplification=E2=80=99 option) wi= th varying degrees of impact. More complex cases will have to be translated by hand over time. > - Follow up: is your intention to adjust the script to work with more > and more package definitions or are you leaning into a more "let's > have a sound script which is useful for many cases but leaves a > biggish bunch of manual labor but at least it won't break a thing" > kind of solution? We can always improve the script if we find that it doesn=E2=80=99t handle idioms that are quite widespread. We can reduce the amount of manual labor but it won=E2=80=99t be zero. > - Is there a way to check the integrity of a package definition > *without* building the whole thing? I had some ideas (see below) > for adding special cases to your `guix style` script but was unable > to test whether they actually work (because compiling tonnes of > codes unsurprisingly takes quite some time). Yes, you can run =E2=80=98guix build -d PACKAGE=E2=80=99 before and after r= unning =E2=80=98guix style=E2=80=99 and confirm the derivation is the same (this is for =E2=80=98--input-simplification=3Dsilent=E2=80=99). > What I found: > - Small things like libX11 vs libx11. If I understood correctly the > new patch series takes care of this case. Yes, with =E2=80=98--input-simplification=3D{safe,always}=E2=80=99. > - I think there's a whole class of cases where version-names and > other package-definition specifics make the "does-the-package-name- > match-the-label-exactly" algo fail: > - ,python-wrapper vs. "python" > - ,python-minimal-wrapper vs. "python" > - ,python2 vs. "python" > - ,python-cython vs. "cython" > - ,iproute2 vs. "iproute" > - etc True! =E2=80=98guix lint -c input-labels=E2=80=99 reports tons of them, bu= t =E2=80=98guix style --input-simplification=3Dsafe=E2=80=99 should also handle most of them (though I didn=E2=80=99t measure that). At worst we can always add special cases to the =E2=80=98label-matches?=E2= =80=99 predicate. Thanks for your feedback! It=E2=80=99s very useful to have feedback from another person who=E2=80=99s looked into it and who might find issues that = have been overlooked. Ludo=E2=80=99.