unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / Atom feed
* Flag day for simplified package inputs
@ 2021-11-19 15:11 Ludovic Courtès
  2021-11-19 15:29 ` Jelle Licht
  0 siblings, 1 reply; 7+ messages in thread
From: Ludovic Courtès @ 2021-11-19 15:11 UTC (permalink / raw)
  To: Guix Devel

Hello Guix!

As a reminder, the plan I proposed¹ is to have a “flag day” shortly
before ‘core-updates-frozen’ is merged into ‘master’ when we would run
‘guix style’ on the whole repo, thereby removing input labels from most
packages.

Doing that before merging will (1) let us ensure there are no rebuilds
or, if rebuilds need to happen, that they’ll take place before the
merge, and (2) reduce chances of merge conflicts.

(‘guix style’ by default changes packages in a way that does not trigger
a rebuild; ‘guix style --input-simplification=safe’, which we may also
want to run, can trigger rebuilds.)

If everything goes well, this could happen in a few days.

Thoughts?

Ludo’.

¹ https://issues.guix.gnu.org/49169#16


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Flag day for simplified package inputs
  2021-11-19 15:11 Flag day for simplified package inputs Ludovic Courtès
@ 2021-11-19 15:29 ` Jelle Licht
  2021-11-22 13:22   ` Ludovic Courtès
  0 siblings, 1 reply; 7+ messages in thread
From: Jelle Licht @ 2021-11-19 15:29 UTC (permalink / raw)
  To: Ludovic Courtès, Guix Devel

Hey Guix,

Ludovic Courtès <ludo@gnu.org> writes:

> Hello Guix!
>
> As a reminder, the plan I proposed¹ is to have a “flag day” shortly
> before ‘core-updates-frozen’ is merged into ‘master’ when we would run
> ‘guix style’ on the whole repo, thereby removing input labels from most
> packages.
<snip>
> If everything goes well, this could happen in a few days.
>
> Thoughts?
Slightly OT, but I think we should think about it now rather than after
the merge.

As with any bulk change, this change will clobber git blame for the
forseeable future for a big chunk of the code.

When applying this and future bulk changes, could we perhaps list the
specific commits (+ commented shortlog line) in a file. To clarify, if
we were to store these commits in `.git-blame-ignore-revs', later on we
can instruct users to run:

--8<---------------cut here---------------start------------->8---
git config blame.ignoreRevsFile .git-blame-ignore-revs
--8<---------------cut here---------------end--------------->8---

to ignore the bulk change for git blame purposes.

It seems like a maintainable way to mitigate some of the (IMO) major
disadvantages that we bring in by applying bulk changes.

NB, we could still ponder and discuss this approach at a later point in
time, but perhaps we want to deal with some of these issues in a
different way that cannot be delayed as easily.

WDYT?
- Jelle


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Flag day for simplified package inputs
  2021-11-19 15:29 ` Jelle Licht
@ 2021-11-22 13:22   ` Ludovic Courtès
  2021-11-22 15:13     ` Jelle Licht
  0 siblings, 1 reply; 7+ messages in thread
From: Ludovic Courtès @ 2021-11-22 13:22 UTC (permalink / raw)
  To: Jelle Licht; +Cc: Guix Devel

Hi,

Jelle Licht <jlicht@fsfe.org> skribis:

> When applying this and future bulk changes, could we perhaps list the
> specific commits (+ commented shortlog line) in a file. To clarify, if
> we were to store these commits in `.git-blame-ignore-revs', later on we
> can instruct users to run:
>
> git config blame.ignoreRevsFile .git-blame-ignore-revs
>
> to ignore the bulk change for git blame purposes.

Sounds like a good idea.  There’s no particular convention regarding the
file name of ‘.git-blame-ignore-revs’, right?

> It seems like a maintainable way to mitigate some of the (IMO) major
> disadvantages that we bring in by applying bulk changes.

The disadvantage of changes is that they introduce changes, indeed.  :-)

But really, I think we should be able to find relevant hints as comments
and use VCS history more as a last resort.

Thanks,
Ludo’.


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Flag day for simplified package inputs
  2021-11-22 13:22   ` Ludovic Courtès
@ 2021-11-22 15:13     ` Jelle Licht
  2021-11-23 17:08       ` Ludovic Courtès
  0 siblings, 1 reply; 7+ messages in thread
From: Jelle Licht @ 2021-11-22 15:13 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: Guix Devel


Hello there,

Ludovic Courtès <ludo@gnu.org> writes:

> Hi,
>
> Jelle Licht <jlicht@fsfe.org> skribis:
>
>> When applying this and future bulk changes, could we perhaps list the
>> specific commits (+ commented shortlog line) in a file. To clarify, if
>> we were to store these commits in `.git-blame-ignore-revs', later on we
>> can instruct users to run:
>>
>> git config blame.ignoreRevsFile .git-blame-ignore-revs
>>
>> to ignore the bulk change for git blame purposes.
>
> Sounds like a good idea.  There’s no particular convention regarding the
> file name of ‘.git-blame-ignore-revs’, right?

As far as I know there is no established convention, although after
searching around a bit I found that Sarah Morgensen proposed the exact
same thing in September. It seems the chromium project also follows the
same naming scheme, so we won't be totally idiosyncratic at least :).


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Flag day for simplified package inputs
  2021-11-22 15:13     ` Jelle Licht
@ 2021-11-23 17:08       ` Ludovic Courtès
  2021-11-29 11:49         ` Jelle Licht
  0 siblings, 1 reply; 7+ messages in thread
From: Ludovic Courtès @ 2021-11-23 17:08 UTC (permalink / raw)
  To: Jelle Licht; +Cc: Guix Devel

Hi,

Jelle Licht <jlicht@fsfe.org> skribis:

> Ludovic Courtès <ludo@gnu.org> writes:
>
>> Hi,
>>
>> Jelle Licht <jlicht@fsfe.org> skribis:
>>
>>> When applying this and future bulk changes, could we perhaps list the
>>> specific commits (+ commented shortlog line) in a file. To clarify, if
>>> we were to store these commits in `.git-blame-ignore-revs', later on we
>>> can instruct users to run:
>>>
>>> git config blame.ignoreRevsFile .git-blame-ignore-revs
>>>
>>> to ignore the bulk change for git blame purposes.
>>
>> Sounds like a good idea.  There’s no particular convention regarding the
>> file name of ‘.git-blame-ignore-revs’, right?
>
> As far as I know there is no established convention, although after
> searching around a bit I found that Sarah Morgensen proposed the exact
> same thing in September. It seems the chromium project also follows the
> same naming scheme, so we won't be totally idiosyncratic at least :).

Good.  :-)  Could you (or Sarah?) propose a patch, including a sentence
or two in the manual with the ‘git config’ snippet?

Thanks,
Ludo’.


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Flag day for simplified package inputs
  2021-11-23 17:08       ` Ludovic Courtès
@ 2021-11-29 11:49         ` Jelle Licht
  2021-12-01 17:50           ` Ludovic Courtès
  0 siblings, 1 reply; 7+ messages in thread
From: Jelle Licht @ 2021-11-29 11:49 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: Guix Devel


Hello there,

Ludovic Courtès <ludo@gnu.org> writes:

> Hi,
>
> Jelle Licht <jlicht@fsfe.org> skribis:
>
>> Ludovic Courtès <ludo@gnu.org> writes:
>>
>>> Hi,
>>>
>>> Jelle Licht <jlicht@fsfe.org> skribis:
>>>
>>>> When applying this and future bulk changes, could we perhaps list the
>>>> specific commits (+ commented shortlog line) in a file. To clarify, if
>>>> we were to store these commits in `.git-blame-ignore-revs', later on we
>>>> can instruct users to run:
>>>>
>>>> git config blame.ignoreRevsFile .git-blame-ignore-revs
>>>>
>>>> to ignore the bulk change for git blame purposes.
>>>
>>> Sounds like a good idea.  There’s no particular convention regarding the
>>> file name of ‘.git-blame-ignore-revs’, right?
>>
>> As far as I know there is no established convention, although after
>> searching around a bit I found that Sarah Morgensen proposed the exact
>> same thing in September. It seems the chromium project also follows the
>> same naming scheme, so we won't be totally idiosyncratic at least :).
>
> Good.  :-)  Could you (or Sarah?) propose a patch, including a sentence
> or two in the manual with the ‘git config’ snippet?

I will work on that. Do we already have a suitable 'bulk change' in the
repo? Or should we first run `guix style', and subsequently use that
commit as the first entry in the .git-blame-ignore-revs file?

- Jelle


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Flag day for simplified package inputs
  2021-11-29 11:49         ` Jelle Licht
@ 2021-12-01 17:50           ` Ludovic Courtès
  0 siblings, 0 replies; 7+ messages in thread
From: Ludovic Courtès @ 2021-12-01 17:50 UTC (permalink / raw)
  To: Jelle Licht; +Cc: Guix Devel

Hi,

Jelle Licht <jlicht@fsfe.org> skribis:

> I will work on that. Do we already have a suitable 'bulk change' in the
> repo? Or should we first run `guix style', and subsequently use that
> commit as the first entry in the .git-blame-ignore-revs file?

The latter I guess.

Thanks,
Ludo’.


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2021-12-01 17:50 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-19 15:11 Flag day for simplified package inputs Ludovic Courtès
2021-11-19 15:29 ` Jelle Licht
2021-11-22 13:22   ` Ludovic Courtès
2021-11-22 15:13     ` Jelle Licht
2021-11-23 17:08       ` Ludovic Courtès
2021-11-29 11:49         ` Jelle Licht
2021-12-01 17:50           ` Ludovic Courtès

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).