unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Mekeor Melire <mekeor@posteo.de>
To: guix-devel@gnu.org
Cc: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Subject: Re: New section to easily reference Debbugs URLs within Emacs Debbugs
Date: Mon, 25 Sep 2023 21:53:58 +0000	[thread overview]
Message-ID: <87v8bxud74.fsf@posteo.de> (raw)
In-Reply-To: <87zg19udmy.fsf@posteo.de>

[-- Attachment #1: Type: text/plain, Size: 1785 bytes --]

2023-09-25 21:27 mekeor@posteo.de:

> 2023-09-17 16:51 maxim.cournoyer@gmail.com:
>
> > Hello,
>
> Hello Maxim,
>
> > If you use Emacs and Emacs-Debbugs, you may be interested in
> > applying the settings newly documented in the 'Viewing Bugs 
> > within
> > Emacs' section of the manual; see it at the bottom of info 
> > "(guix)
> > The Perfect Setup").
> >
> > I hope that's useful,
>
> Thank you for sharing. The new section is very useful for me. I 
> have
> two things to feed back though.
>
>
> First feedback: I think the new section should instruct to set 
> the
> `bug-reference-url-format'. I.e. we should add this to the 
> suggested
> code snippet: (setq bug-reference-url-format
> "https://issues.guix.gnu.org/%s"). Otherwise, the suggested code
> snippet results in an error when a bug reference is clicked. See
> appendix.
>
>
> Second feedback: It might be nice to write regular-expressions 
> using
> the `rx' macro, but imho writing them as strings is shorter,
> unobtrusive and thus preferable for average Guix users. I.e. I'd
> suggest to replace the two setq-expressions of code that the new
> manual section suggests, with the following S-expressions
> respectively:
>
> (setq bug-reference-bug-regexp "\\(\\b\\(?:[Bb]ug ?#?\\|[Pp]atch
> ?#\\|[Ff]ixes:? ?#\\|RFE ?#\\|PR
> [+a-z-]+/\\)\\([0-9]+\\(?:#[0-9]+\\)?\\)\\|<https://bugs\\.gnu\\.org/\\(?2:[0-9]+\\)>\\)")
>
> (setq debbugs-browse-url-regexp
> "^https?://\\(?:bugs\\|debbugs\\|issues\\.guix\\)\\.gnu\\.org/+\\(\\(?:cgi/bugreport\\.cgi\\?bug=\\)?\\)\\(?3:[[:digit:]]+\\)$")
>
>
> WDYT?
>
>
> [2. application/emacs-lisp; reproduce-error.el]...

Third thought: Use #' for quoting functions consistently. Maybe do 
some code alignment.

Putting all three thoughts together, I'd gather this code suggestion:


[-- Attachment #2: new.el --]
[-- Type: application/emacs-lisp, Size: 859 bytes --]

  reply	other threads:[~2023-09-25 22:00 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-17 20:51 New section to easily reference Debbugs URLs within Emacs Debbugs Maxim Cournoyer
2023-09-18 16:07 ` Notmuch, Debbugs: my helpers (was Re: New section to easily reference Debbugs URLs within Emacs Debbugs) Simon Tournier
2023-09-20 18:13   ` Maxim Cournoyer
2023-09-21  7:58     ` Helpers? " Simon Tournier
2023-09-25 21:27 ` New section to easily reference Debbugs URLs within Emacs Debbugs Mekeor Melire
2023-09-25 21:53   ` Mekeor Melire [this message]
2023-09-26  8:27     ` Mekeor Melire
2023-10-04 20:39       ` Mekeor Melire
2023-10-05 17:19         ` Maxim Cournoyer
2023-10-18 15:32         ` Brian Cully via Development of GNU Guix and the GNU System distribution.

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v8bxud74.fsf@posteo.de \
    --to=mekeor@posteo.de \
    --cc=guix-devel@gnu.org \
    --cc=maxim.cournoyer@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).