Re: [PATCH] gnu: Add abbaye

[David Thompson <dthompson2@worcester.edu>]

Ludovic Courtès <ludo@gnu.org> writes:

> David Thompson <dthompson2@worcester.edu> skribis:
>
>> From 040828eabadf401743c4811c26dfb9220f8052d0 Mon Sep 17 00:00:00 2001
>> From: David Thompson <dthompson@member.fsf.org>
>> Date: Wed, 30 Apr 2014 20:36:32 -0400
>> Subject: [PATCH 2/2] gnu: Add abbaye.
>>
>> * gnu/packages/games.scm (abbaye): New variable.
>
> Minor comments:
>
>>  gnu/packages/games.scm | 63 ++++++++++++++++++++++++++++++++++++++++++++++++++
>>  1 file changed, 63 insertions(+)
>>
>> diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
>> index 46fbd21..3caef32 100644
>> --- a/gnu/packages/games.scm
>> +++ b/gnu/packages/games.scm
>
> Please add add a copyright line for you in this file.
>
>> +                   ;; Modify CPATH variable to point to include/SDL for SDL header
>> +                   ;; files.
>> +                   (set-path-environment-variable "CPATH"
>> +                                                  '("include/SDL")
>> +                                                  input-directories))
>
> So the crux of the problem is that this package doesn’t use pkg-config,
> right?
>
>> +    (description "l'Abbaye des Morts is a 2D platform game set in 13th century
>
> Capital “L”.
>
> OK to push with these changes.
>
> Thank you!
>
> Ludo’.

Thanks for the feedback.  Fixed and pushed.

- Dave