unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Mark H Weaver <mhw@netris.org>
To: David Thompson <dthompson2@worcester.edu>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add guile-opengl
Date: Fri, 27 Jun 2014 00:08:54 -0400	[thread overview]
Message-ID: <87tx77t2nd.fsf@yeeloong.lan> (raw)
In-Reply-To: <8761jov8nb.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me> (David Thompson's message of "Wed, 25 Jun 2014 20:04:08 -0400")

David Thompson <dthompson2@worcester.edu> writes:
> +                 (lambda* (#:key inputs outputs #:allow-other-keys)
> +                   (define (dynamic-link-substitute file lib input)
> +                     (substitute* file
> +                       (("dynamic-link \"lib([a-zA-Z]+)\"" _ lib)
> +                        (string-append "dynamic-link \""
> +                                       (assoc-ref inputs input)
> +                                       "/lib/lib" lib "\""))))

I think the 'substitute*' form binds 'lib' to whatever matched the
pattern ([a-zA-z]+), thus shadowing the 'lib' argument to
'dynamic-link-substitute', so I think you could simply remove that
argument, or no?

> +                   ;; Replace dynamic-link calls for libGL, libGLU, and
> +                   ;; libglut with absolute paths to the store.
> +                   (dynamic-link-substitute "glx/runtime.scm" "GL" "mesa")
> +                   (dynamic-link-substitute "glu/runtime.scm" "GLU" "mesa")
> +                   (dynamic-link-substitute "glut/runtime.scm" "glut"
> +                                            "freeglut"))
> +                 %standard-phases)))

   Thanks!
     Mark

      parent reply	other threads:[~2014-06-27  4:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-25  2:03 [PATCH] gnu: Add guile-opengl David Thompson
2014-06-25 19:29 ` Ludovic Courtès
2014-06-26  0:04   ` David Thompson
2014-06-26 12:41     ` Ludovic Courtès
2014-06-27  4:08     ` Mark H Weaver [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tx77t2nd.fsf@yeeloong.lan \
    --to=mhw@netris.org \
    --cc=dthompson2@worcester.edu \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).