From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: =?utf-8?B?4oCYc3RyaXDigJk=?= phase
Date: Mon, 27 Oct 2014 10:05:41 +0100
Message-ID: <87tx2panmi.fsf_-_@gnu.org>
References: <20141026203111.GA20849@thebird.nl> <87wq7mpfs0.fsf@yeeloong.lan>
	<20141026234436.GA21721@thebird.nl> <87siiap9s5.fsf@yeeloong.lan>
	<20141027015650.GB21971@thebird.nl> <87k33m179b.fsf@netris.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53348)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1XigEy-0002ld-Jd
	for guix-devel@gnu.org; Mon, 27 Oct 2014 05:05:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1XigEs-0000I9-K8
	for guix-devel@gnu.org; Mon, 27 Oct 2014 05:05:28 -0400
Received: from hera.aquilenet.fr ([2a01:474::1]:41959)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1XigEs-0000I5-CG
	for guix-devel@gnu.org; Mon, 27 Oct 2014 05:05:22 -0400
In-Reply-To: <87k33m179b.fsf@netris.org> (Mark H. Weaver's message of "Mon, 27
	Oct 2014 00:11:44 -0400")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Mark H Weaver <mhw@netris.org>
Cc: guix-devel@gnu.org

Mark H Weaver <mhw@netris.org> skribis:

>> I DO get a load of messages such as
>>
>>   strip:/gnu/store/icz59y35qqmm4jcrnkqx7d73xlzsq0lq-ruby-1.8.7-p374/lib/=
ruby/1.8/rexml/attlistdecl.rb:
>>   File format not recognized
>>
>> is there a way to prevent files with a .rb extension or ruby shebang
>> to be stripped?
>
> In theory the default 'strip' phase could be replaced by one that's more
> selective, but please don't do that.
>
> The problem happens in almost every package, so the improvements should
> be made in the default 'strip' phase.  The relevant procedure is 'strip'
> in guix/build/gnu-build-system.scm, but beware that changing that file
> (or just about anything else in that directory) will trigger a full
> rebuild of all packages.  It would be nice to do at some point, but it's
> quite far down on our TODO list.

I think the =E2=80=98strip=E2=80=99 phase is fine this way: sure, it ends u=
p invoking
=E2=80=98strip=E2=80=99 on files that are not ELF files, but it=E2=80=99s h=
armless.  So we get
these extra warnings in the build log, but they are really harmless.

Conversely, attempts to be more selective may miss actual ELF files.

WDYT?

Ludo=E2=80=99.