From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH]: Add CUPS.
Date: Thu, 15 Jan 2015 21:21:39 +0100
Message-ID: <87twzr4wx8.fsf@gnu.org>
References: <idjy4phz8e3.fsf@bimsb-sys02.mdc-berlin.net>
	<874ms5qlya.fsf@gnu.org> <idjvbklyy04.fsf@bimsb-sys02.mdc-berlin.net>
	<idjfvbkypbz.fsf@bimsb-sys02.mdc-berlin.net> <87mw5qna67.fsf@gnu.org>
	<idjfvbcgg5u.fsf@bimsb-sys02.mdc-berlin.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48975)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1YBqvJ-0002pY-RB
	for guix-devel@gnu.org; Thu, 15 Jan 2015 15:21:46 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1YBqvG-0002Dc-LN
	for guix-devel@gnu.org; Thu, 15 Jan 2015 15:21:45 -0500
Received: from hera.aquilenet.fr ([2a01:474::1]:41248)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1YBqvG-0002DU-EO
	for guix-devel@gnu.org; Thu, 15 Jan 2015 15:21:42 -0500
In-Reply-To: <idjfvbcgg5u.fsf@bimsb-sys02.mdc-berlin.net> (Ricardo Wurmus's
	message of "Thu, 15 Jan 2015 17:30:37 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: guix-devel <guix-devel@gnu.org>

Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:

> From a78114013bdbbff310014815cb47abd38bb0c59c Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> Date: Wed, 14 Jan 2015 14:47:37 +0100
> Subject: [PATCH 1/2] gnu: Add IJS
>
> * gnu/packages/ghostscript.scm (ijs): New variable.

[...]

> +(define-public ijs
> +  (package
> +   (name "ijs")
> +   (version "9.14.0")
> +   (source (origin
> +            (method url-fetch)
> +            (uri (string-append "mirror://gnu/ghostscript/gnu-ghostscrip=
t-"
> +                                version ".tar.xz"))
> +            (sha256 (base32
> +                     "0q4jj41p0qbr4mgcc9q78f5zs8cm1g57wgryhsm2yq4lfslm3i=
b1"))))
> +   (build-system gnu-build-system)
> +   (native-inputs
> +    `(("libtool"    ,libtool "bin")
> +      ("libtool"    ,libtool "out")
> +      ("automake"   ,automake)
> +      ("autoconf"   ,autoconf)))

I=E2=80=99m surprised ,(autoconf-wrapper) isn=E2=80=99t needed rather than =
,autoconf
(the former has shebangs of generated files patched appropriately.)  But
if it works this way, OK to push.

> From 72a50808f1b2d3f391b5da688bfe0b841d95af30 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> Date: Mon, 5 Jan 2015 13:56:51 +0100
> Subject: [PATCH 2/2] gnu: Add CUPS.
>
> * gnu/packages/cups.scm: New file.
> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.

LGTM.

Thank you!

Ludo=E2=80=99.