Re: [PATCH]: Add CUPS.

[ludo@gnu.org (Ludovic Courtès)]

Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:

> From a78114013bdbbff310014815cb47abd38bb0c59c Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> Date: Wed, 14 Jan 2015 14:47:37 +0100
> Subject: [PATCH 1/2] gnu: Add IJS
>
> * gnu/packages/ghostscript.scm (ijs): New variable.

[...]

> +(define-public ijs
> +  (package
> +   (name "ijs")
> +   (version "9.14.0")
> +   (source (origin
> +            (method url-fetch)
> +            (uri (string-append "mirror://gnu/ghostscript/gnu-ghostscript-"
> +                                version ".tar.xz"))
> +            (sha256 (base32
> +                     "0q4jj41p0qbr4mgcc9q78f5zs8cm1g57wgryhsm2yq4lfslm3ib1"))))
> +   (build-system gnu-build-system)
> +   (native-inputs
> +    `(("libtool"    ,libtool "bin")
> +      ("libtool"    ,libtool "out")
> +      ("automake"   ,automake)
> +      ("autoconf"   ,autoconf)))

I’m surprised ,(autoconf-wrapper) isn’t needed rather than ,autoconf
(the former has shebangs of generated files patched appropriately.)  But
if it works this way, OK to push.

> From 72a50808f1b2d3f391b5da688bfe0b841d95af30 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> Date: Mon, 5 Jan 2015 13:56:51 +0100
> Subject: [PATCH 2/2] gnu: Add CUPS.
>
> * gnu/packages/cups.scm: New file.
> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.

LGTM.

Thank you!

Ludo’.