From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark H Weaver Subject: Re: [PATCH] bump mu/mu4e to version 0.9.11 Date: Thu, 26 Feb 2015 19:00:56 -0500 Message-ID: <87twy86x53.fsf@netris.org> References: <87wq34nu5j.fsf@denknerd.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:35520) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YR8MK-0000XC-Hp for guix-devel@gnu.org; Thu, 26 Feb 2015 19:00:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YR8MG-0008Rg-Bu for guix-devel@gnu.org; Thu, 26 Feb 2015 19:00:48 -0500 Received: from world.peace.net ([50.252.239.5]:43111) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YR8MG-0008RP-2b for guix-devel@gnu.org; Thu, 26 Feb 2015 19:00:44 -0500 In-Reply-To: <87wq34nu5j.fsf@denknerd.org> (Paul van der Walt's message of "Fri, 27 Feb 2015 00:13:28 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Paul van der Walt Cc: Guix-devel Paul van der Walt writes: > Here's my first modest patch. I use mu4e, and therefore it bothered me > that the version in Guix was about a year old. The upgraded version > seems to work fine for me, so that's nice. Looks good to me, modulo a few minor nits. Please see below. > * gnu/packages/mail.scm: Bump mu version from 0.9.9.5 -> 0.9.11 By our usual conventions, the commit log should look like this: --8<---------------cut here---------------start------------->8--- gnu: mu: Update to 0.9.11. * gnu/packages/mail.scm (mu): Update to 0.9.11. --8<---------------cut here---------------end--------------->8--- > diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm > index dc33c8c..b450e91 100644 > --- a/gnu/packages/mail.scm > +++ b/gnu/packages/mail.scm Please add your copyright line to the top of the file. > @@ -304,18 +304,21 @@ repository and Maildir/IMAP as LOCAL repository.") > (define-public mu > (package > (name "mu") > - (version "0.9.9.5") > + (version "0.9.11") > (source (origin > (method url-fetch) > - (uri (string-append "https://mu0.googlecode.com/files/mu-" > + (uri (string-append "https://github.com/djcb/mu/archive/v" > version ".tar.gz")) Please add (file-name (string-append "mu-" version ".tar.gz")) as another field to the 'origin' form, so that the file name in /gnu/store will include "mu-" in the name. This is rarely needed, but is needed here because the name of the file in the URI (after the last '/') doesn't include the package name. Otherwise it looks good to me. Can you send an updated patch? Thanks! Mark