From: Mark H Weaver <mhw@netris.org>
To: David Thompson <dthompson2@worcester.edu>
Cc: guix-devel@gnu.org
Subject: Re: [PATCHES] gnu: Add livestreamer.
Date: Sun, 05 Apr 2015 01:13:14 -0400 [thread overview]
Message-ID: <87twwv40ph.fsf@netris.org> (raw)
In-Reply-To: <87zj6ng65y.fsf@fsf.org> (David Thompson's message of "Sat, 04 Apr 2015 13:22:17 -0400")
David Thompson <dthompson2@worcester.edu> writes:
> This small patch set adds livestreamer, which is like youtube-dl but for
> live streaming websites, and its missing dependencies.
Excellent! See below for comments.
> From 67f1a7d362f9d379b4fa5f905b01193b5531509d Mon Sep 17 00:00:00 2001
> From: David Thompson <dthompson2@worcester.edu>
> Date: Sat, 4 Apr 2015 13:15:40 -0400
> Subject: [PATCH 1/3] gnu: python-requests: Fix Python 2 version and add
> support for Python 3.
Looks good!
> From 472370aabae4171e69eccf8927aa09337b49cfcf Mon Sep 17 00:00:00 2001
> From: David Thompson <dthompson2@worcester.edu>
> Date: Sat, 4 Apr 2015 13:17:35 -0400
> Subject: [PATCH 2/3] gnu: Add python-singledispatch.
>
> * gnu/packages/python.scm (python-singledispath, python2-singledispatch): New
Typo: "python-singledispath" is missing the "c".
> variables.
> ---
> gnu/packages/python.scm | 30 ++++++++++++++++++++++++++++++
> 1 file changed, 30 insertions(+)
>
>
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index 8c86d5a..8f19f89 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -3448,3 +3448,33 @@ Python style, together with a fast and comfortable execution environment.")
> library for Python programs. It is useful to implement low-level X clients.
> It is written entirely in Python.")
> (license gpl2+)))
> +
> +(define-public python-singledispatch
> + (package
> + (name "python-singledispatch")
> + (version "3.4.0.3")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append
> + "https://pypi.python.org/packages/source/s/singledispatch/singledispatch-"
> + version
> + ".tar.gz"))
To avoid the long lines, how about this?
--8<---------------cut here---------------start------------->8---
(uri (string-append
"https://pypi.python.org/packages/source/s/singledispatch/"
"singledispatch-" version ".tar.gz"))
--8<---------------cut here---------------end--------------->8---
> From af76cababb6550081be6aaf9db45ef370b278df1 Mon Sep 17 00:00:00 2001
> From: David Thompson <dthompson2@worcester.edu>
> Date: Sat, 4 Apr 2015 13:18:40 -0400
> Subject: [PATCH 3/3] gnu: Add livestreamer.
>
> * gnu/packages/video.scm (livestreamer): New variable.
> ---
> gnu/packages/video.scm | 26 ++++++++++++++++++++++++++
> 1 file changed, 26 insertions(+)
>
>
> diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
> index c6eb859..98f4a3a 100644
> --- a/gnu/packages/video.scm
> +++ b/gnu/packages/video.scm
> @@ -1261,3 +1261,29 @@ codec library. It uses ASP features such as b-frames, global and quarter
> pixel motion compensation, lumi masking, trellis quantization, and H.263, MPEG
> and custom quantization matrices.")
> (license license:gpl2+)))
> +
> +(define-public livestreamer
> + (package
> + (name "livestreamer")
> + (version "1.12.1")
> + (source (origin
> + (method url-fetch)
> + (uri (string-append
> + "https://github.com/chrippa/livestreamer/archive/v"
> + version ".tar.gz"))
Please add a 'file-name' field to this 'origin'. Otherwise the store
name of the source code will be /gnu/store/...-v1.21.1.tar.gz.
Otherwise looks good to me!
Thanks,
Mark
next prev parent reply other threads:[~2015-04-05 5:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-04 17:22 [PATCHES] gnu: Add livestreamer David Thompson
2015-04-05 5:13 ` Mark H Weaver [this message]
2015-04-05 16:44 ` David Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87twwv40ph.fsf@netris.org \
--to=mhw@netris.org \
--cc=dthompson2@worcester.edu \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).