unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Mathieu Lirzin <mthl@openmailbox.org>
To: guix-devel@gnu.org
Subject: 'origin' indentation rule.
Date: Thu, 10 Sep 2015 23:26:17 +0200	[thread overview]
Message-ID: <87twr2neyu.fsf@openmailbox.org> (raw)

Hi,

While reviewing patches I got confused when I discovered that
indentation for 'origin' is not consistent in package definitions.

Since commit 35ef3633001b05c25324c6e5a69d635ddc62cb6d, which add

   (eval . (put 'origin 'scheme-indent-function 0))

In .dir-locals.el, it seems that there has been quite a lot of commits
since then that don't use this rule.  Even in the manual the "suggested"
way is not clear since for example "doc/package-hello.scm" uses the rule,
but (info "(guix)Defining Packages") doesn't.

I failed to retrieve the post where this rule has been suggested (if
there is one), so I don't know the rationale behind it.  My personnal
opinion is that for the sake of simplicity and column saving we should
remove it. But Whatever the final decision is, I think it's important to be
consistent at least in the manual and the importers.

--
Mathieu Lirzin

             reply	other threads:[~2015-09-10 21:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-10 21:26 Mathieu Lirzin [this message]
2015-09-11 17:08 ` 'origin' indentation rule Ludovic Courtès
2015-09-11 17:09   ` Thompson, David
2015-09-11 19:12     ` Mathieu Lirzin
2015-09-11 19:35   ` Mathieu Lirzin
2015-09-11 20:57     ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87twr2neyu.fsf@openmailbox.org \
    --to=mthl@openmailbox.org \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).