From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] build: ruby: Add support for tarball and directory
	sources.
Date: Mon, 14 Sep 2015 10:08:06 +0200
Message-ID: <87twqxv2xl.fsf@gnu.org>
References: <87fv2pmx5v.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57722)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ZbOrM-0006iB-Hk
	for guix-devel@gnu.org; Mon, 14 Sep 2015 04:11:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ZbOrH-0007qK-5b
	for guix-devel@gnu.org; Mon, 14 Sep 2015 04:11:32 -0400
In-Reply-To: <87fv2pmx5v.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me>
	(David Thompson's message of "Mon, 07 Sep 2015 23:01:48 -0400")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: David Thompson <dthompson2@worcester.edu>
Cc: guix-devel@gnu.org

David Thompson <dthompson2@worcester.edu> skribis:

> From 612a4a692375f241934de03d24064dbef1c7294c Mon Sep 17 00:00:00 2001
> From: David Thompson <dthompson2@worcester.edu>
> Date: Mon, 7 Sep 2015 22:58:05 -0400
> Subject: [PATCH] build: ruby: Add support for tarball and directory sourc=
es.
>
> Previously, the Ruby build system only knew how to work with gem archives,
> which made it difficult to build unreleased gems from a Git repository or
> released gems in tarball form.
>
> * gnu/build/ruby-build-system.scm (gnu:unpack, gem-archive?): New procedu=
res.
>   (unpack): Use GNU build system unpack phase for non-gem sources.
>   (build): Rebuild the gemspec iff the source is a gem archive.

I trust you for all things Ruby, but it looks good.

Should the manual mention that both Gems and raw checkouts are handled?

Thanks,
Ludo=E2=80=99.