unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: "Thompson, David" <dthompson2@worcester.edu>
Cc: guix-devel <guix-devel@gnu.org>, Alex Kost <alezost@gmail.com>
Subject: Re: [PATCH 2/2] gnu: Add manaplus.
Date: Fri, 09 Oct 2015 23:56:36 +0200	[thread overview]
Message-ID: <87twpz4sff.fsf@gnu.org> (raw)
In-Reply-To: <CAJ=RwfYdT2kcC1JOsmVgBdrOTWtF71ORP2tWAXbZYt50M4tgvg@mail.gmail.com> (David Thompson's message of "Fri, 9 Oct 2015 12:56:28 -0400")

"Thompson, David" <dthompson2@worcester.edu> skribis:

> On Fri, Oct 9, 2015 at 8:40 AM, Ludovic Courtès <ludo@gnu.org> wrote:
>> Alex Kost <alezost@gmail.com> skribis:
>>
>>> I don't know if there is a better workaround for the SDL headers, but
>>> this problem is rather common: there is a workaround in 'abbaye' and a
>>> special patch for 'pingus'.
>>>
>>> The problem is: the source code has lines like this:
>>>
>>>   #include <SDL_mixer.h>
>>>
>>> but the headers of all SDL packages are placed in “include/SDL/”
>>> subdirectories.  And an upstream often doesn't use "pkg-config" for
>>> every SDL package to define CFLAGS and assumes that all SDL headers are
>>> placed in one directory.  So we have to invent workarounds for such
>>> packages.
>>>
>>> I just mention this problem here, perhaps someone will come up with a
>>> general solution.
>>
>> Can’t ‘sdl-union’ be used here?  I think it was created specifically to
>> solve this problem.  (Currently it’s private to (gnu packages sdl) but
>> you can export it.)
>
> Do you have any concerns about this package being picked up by UIs now
> that it will be public?  Might confuse a user or two, dunno.

No opinion.  If you think we’d rather keep it hidden, we can wrap it in
a thunk for instance so that the UIs don’t pick it up.  WDYT?

Ludo’.

  reply	other threads:[~2015-10-09 21:56 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-04 19:16 [PATCH 2/2] gnu: Add manaplus Alex Kost
2015-10-09 12:40 ` Ludovic Courtès
2015-10-09 16:56   ` Thompson, David
2015-10-09 21:56     ` Ludovic Courtès [this message]
2015-10-10  8:48       ` [PATCH] gnu: sdl-union: Wrap into a procedure and export it Alex Kost
2015-10-11 16:50         ` Ludovic Courtès
2015-10-12  8:54           ` Alex Kost
2015-10-10  8:48   ` [PATCH 2/2] gnu: Add manaplus Alex Kost
2015-10-11 16:52     ` Ludovic Courtès
2015-10-12  8:54       ` Alex Kost
2015-10-12 16:35         ` Ludovic Courtès
2015-10-13 10:34           ` [PATCH] gnu: abbaye: Use 'sdl-union' Alex Kost
2015-10-13 14:01             ` Thompson, David
2015-10-14 16:23               ` Alex Kost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87twpz4sff.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=alezost@gmail.com \
    --cc=dthompson2@worcester.edu \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).