From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paul van der Walt <paul@denknerd.org>
Subject: Re: [PATCH 032/151] gnu: Add ghc-hspec-discover.
Date: Tue, 20 Oct 2015 15:30:12 +0200
Message-ID: <87twpl4qhn.fsf@denknerd.org>
References: <1444911697-15515-22-git-send-email-paul@denknerd.org>
	<1445266613-11794-1-git-send-email-ericbavier@openmailbox.org>
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54139)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paul@denknerd.org>) id 1ZoWzg-00059p-6k
	for guix-devel@gnu.org; Tue, 20 Oct 2015 09:30:25 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paul@denknerd.org>) id 1ZoWzc-0000rY-7e
	for guix-devel@gnu.org; Tue, 20 Oct 2015 09:30:24 -0400
Received: from mx01.mykolab.com ([95.128.36.1]:37731 helo=mx-out03.mykolab.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paul@denknerd.org>) id 1ZoWzc-0000r4-20
	for guix-devel@gnu.org; Tue, 20 Oct 2015 09:30:20 -0400
In-reply-to: <1445266613-11794-1-git-send-email-ericbavier@openmailbox.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: ericbavier@openmailbox.org
Cc: guix-devel@gnu.org

Hi Eric,

I'm starting to fix up your comments.

When i'm done, should i git push -f to the wip-haskell-platform-7.10.2-a
branch, or should i drop that one and create a new one?

On 2015-10-19 at 16:56, quoth ericbavier@openmailbox.org:
> +(define-public ghc-hspec-discover
> +  (package
> +    (name "ghc-hspec-discover")
>
> IMHO the name should be "hspec-discover" as this is a standalone program,
> rather than a haskell library.

Changed.

> +    (arguments `(#:haddock? #f))
>
> Add a comment here noting how there are no documentation files.

Done.

> +    (description "Automatically discover and run Hspec tests.")
>
> Expand this to a full sentence.

Done.