From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH] tests: Skip 'guix environment --container' tests in some cases. Date: Wed, 04 Nov 2015 10:05:48 +0100 Message-ID: <87twp29lsj.fsf@gnu.org> References: <87h9l24fyn.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:44917) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ztu0z-0000Z8-Ur for guix-devel@gnu.org; Wed, 04 Nov 2015 04:05:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ztu0u-00053V-7Q for guix-devel@gnu.org; Wed, 04 Nov 2015 04:05:57 -0500 In-Reply-To: <87h9l24fyn.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me> (David Thompson's message of "Tue, 03 Nov 2015 22:10:40 -0500") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: David Thompson Cc: guix-devel@gnu.org David Thompson skribis: > Took a stab at fixing the guix-environment-container.sh tests when the > necessary features aren't available. GuixSD systems don't have > /proc/sys/kernel/unprivileged_userns_clone so I couldn't verify that > code path works as intended. All I can say is that the tests still pass > on my machine as they did before. > > WDYT? Did I make it in time for the release? Sounds good in principle, but you forgot to attach the patch. :-) Ludo=E2=80=99.