From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 4/4] services: Add network-manager-service.
Date: Tue, 17 Nov 2015 17:01:13 +0100
Message-ID: <87twok7gza.fsf@gnu.org>
References: <1447653973-3839-1-git-send-email-iyzsong@gmail.com>
	<1447653973-3839-4-git-send-email-iyzsong@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47367)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Zyih7-0005WL-M9
	for guix-devel@gnu.org; Tue, 17 Nov 2015 11:01:27 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Zyih1-0002x7-WB
	for guix-devel@gnu.org; Tue, 17 Nov 2015 11:01:21 -0500
In-Reply-To: <1447653973-3839-4-git-send-email-iyzsong@gmail.com>
	(=?utf-8?B?IuWui+aWh+atpiIncw==?=
	message of "Mon, 16 Nov 2015 14:06:13 +0800")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: =?utf-8?B?5a6L5paH5q2m?= <iyzsong@gmail.com>
Cc: guix-devel@gnu.org

=E5=AE=8B=E6=96=87=E6=AD=A6 <iyzsong@gmail.com> skribis:

> * gnu/services/networking.scm (network-manager-service): New procedure.
> (network-manager-service-type, %network-manager-activation): New variable=
s.
> (network-manager-dmd-service): New procedure.

[...]

> +(define (network-manager-dmd-service network-manager)
> +  "Return a dmd service for NETWORK-MANAGER."
> +  (list (dmd-service
> +         (documentation "Run the NetworkManager.")
> +         (provision '(networking))
> +         (requirement '(user-processes dbus-system loopback))
> +         (start #~(make-forkexec-constructor
> +                   (list (string-append #$network-manager
> +                                        "/sbin/NetworkManager")
> +                         "--no-daemon")))
> +         (stop #~(make-kill-destructor)))))

I guess that even if NM can be activated by dbus-daemon, we prefer to
start it explicitly like this, right?

I suppose relying on dbus activation means that you could end up with no
networking until you actually start network-manager-applet or one of
these clients.

> +                       ;; Add network-manager to the system profile.
> +                       ;; XXX: Should we add network-manager-applet?
> +                       (service-extension profile-service-type list)))))

I think network-manager-applet could be added to profile-service-type,
but only as part of %desktop-services.  WDYT?

Otherwise LGTM!

In a subsequent patch, you can add network-manager-service to
%desktop-services I guess.  :-)

Thank you!

Ludo=E2=80=99.