From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mathieu Lirzin <mthl@gnu.org>
Subject: Re: [PATCH] gnu: bind-utils: Build and install =?utf-8?B?4oCcbnN1?=
	=?utf-8?B?cGRhdGXigJ0u?=
Date: Thu, 21 Jan 2016 14:14:01 +0100
Message-ID: <87twm7krc6.fsf@gnu.org>
References: <idjd1t5frak.fsf@bimsb-sys02.mdc-berlin.net>
	<8760yxt2by.fsf@gnu.org> <87lh7stu35.fsf@gmail.com>
	<idj7fjcfkcv.fsf@bimsb-sys02.mdc-berlin.net> <87mvs7912x.fsf@gnu.org>
	<idjvb6n9pct.fsf@bimsb-sys02.mdc-berlin.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50159)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mthl@gnu.org>) id 1aMF3x-0002f7-NA
	for guix-devel@gnu.org; Thu, 21 Jan 2016 08:14:10 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mthl@gnu.org>) id 1aMF3t-0002B1-Lq
	for guix-devel@gnu.org; Thu, 21 Jan 2016 08:14:09 -0500
In-Reply-To: <idjvb6n9pct.fsf@bimsb-sys02.mdc-berlin.net> (Ricardo Wurmus's
	message of "Thu, 21 Jan 2016 11:52:18 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: Guix-devel <guix-devel@gnu.org>, Alex Kost <alezost@gmail.com>

Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> writes:

> Okay.  Attached are three new patches.  I thought I should better split
> this up into separate commits for clarity.

Splitting thoses changes is a good idea.  Thanks for taking the time to
do it.

>>From b276ca4c3940663137e4449144b2256f03e47d27 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> Date: Thu, 21 Jan 2016 11:20:30 +0100
> Subject: [PATCH 1/3] gnu: bind-utils: Use "modify-phases" syntax.
>
> * gnu/packages/dns.scm (bind-utils): Use "modify-phases" syntax.

OK.

>>From 4c7f432edbd65abad749170a280d88181f533635 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> Date: Thu, 21 Jan 2016 11:41:10 +0100
> Subject: [PATCH 2/3] gnu: bind-utils: Generalize "build" and "install" ph=
ases.
>
> * gnu/packages/dns.scm (bind-utils)[arguments]: Generalize "build" and
>   "install" phases.

OK.

>>From 6bd7b2a30ef1f128097c2ff4030e465e3955a34f Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> Date: Thu, 21 Jan 2016 11:42:17 +0100
> Subject: [PATCH 3/3] gnu: bind-utils: Build and install "nsupdate".
>
> * gnu/packages/dns.scm (bind-utils)[arguments]: Also build and install
>   "nsupdate" executable.

I think =E2=80=9CAlso=E2=80=9D can be removed here.  Otherwise LGTM.

Thanks,

--
Mathieu Lirzin