From: Christopher Allan Webber <cwebber@dustycloud.org>
To: guix-devel@gnu.org
Subject: Inherit inputs when unnecessary in these python2 packages?
Date: Sat, 13 Feb 2016 18:10:17 -0800 [thread overview]
Message-ID: <87twlct53f.fsf@dustycloud.org> (raw)
I'm doing a lot of packaging for Python packages right now. A lot of
the code looks like this:
> (define-public python-execnet
> (package
> (name "python-execnet")
> (version "1.4.1")
> (source (origin
> (method url-fetch)
> (uri (pypi-uri "execnet" version))
> (sha256
> (base32
> "1rpk1vyclhg911p3hql0m0nrpq7q7mysxnaaw6vs29cpa6kx8vgn"))))
> (build-system python-build-system)
> (native-inputs
> `(("python-setuptools-scm" ,python-setuptools-scm)))
> (propagated-inputs
> `(("python-apipkg" ,python-apipkg)))
> (synopsis "Rapid multi-Python deployment")
> (description "Execnet provides a share-nothing model with
> channel-send/receive communication for distributing execution across many
> Python interpreters across version, platform and network barriers. It has a
> minimal and fast API targetting the following uses:
> @enumerate
> @item distribute tasks to (many) local or remote CPUs
> @item write and deploy hybrid multi-process applications
> @item write scripts to administer multiple environments
> @end enumerate")
> (home-page "http://codespeak.net/execnet/")
> (license license:expat)
> (properties `((python2-variant . ,(delay python2-execnet))))))
>
> (define-public python2-execnet
> (package
> (inherit (package-with-python2
> (strip-python2-variant python-execnet)))
> (inputs
> `(("python2-setuptools" ,python2-setuptools)))))
As you can see, there is no inputs on python-execnet, so it's not
necessary to include the inputs. However, if (inputs) were added in the
future, this could lead to a developer mistakenly forgetting to change
the python2 variant.
What's the better approach?
- Chris
next reply other threads:[~2016-02-14 2:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-14 2:10 Christopher Allan Webber [this message]
2016-02-14 3:19 ` Inherit inputs when unnecessary in these python2 packages? Leo Famulari
2016-02-14 14:48 ` Andreas Enge
2016-02-14 19:09 ` Leo Famulari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87twlct53f.fsf@dustycloud.org \
--to=cwebber@dustycloud.org \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).