From: iyzsong@member.fsf.org (宋文武)
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add cgit.
Date: Tue, 29 Mar 2016 12:03:31 +0800 [thread overview]
Message-ID: <87twjq7wx8.fsf@member.fsf.org> (raw)
In-Reply-To: <87wpomr293.fsf@gnu.org> ("Ludovic Courtès"'s message of "Mon, 28 Mar 2016 18:33:28 +0200")
ludo@gnu.org (Ludovic Courtès) writes:
> 宋文武 <iyzsong@gmail.com> skribis:
>
>> * gnu/packages/version-control.scm (cgit): New variable.
>
> [...]
>
>> + (arguments
>> + '(#:tests? #f ;
>
> Please add a comment on why tests are disabled. Better yet: fix’em!
> ;-)
It try to build a some kind of full version of git, but
failed. (I give up on fixing it now.)
>> + (native-inputs
>> + `(("asciidoc" ,asciidoc)
>> + ("xmllint" ,libxml2)
>> + ("xsltprot" ,libxslt)))
>> + (inputs
>> + `(("docbook-xml" ,docbook-xml)
>> + ("docbook-xsl" ,docbook-xsl)
>
> I would move DocBook to ‘native-inputs’.
OK, since they’re only for building the manpage.
>
>> + (description
>> + "CGit is an attempt to create a fast web interface for the Git SCM, using
>> +a built-in cache to decrease server I/O pressure.")
>> + (license gpl2)))
>
> Version 2 only, right?
Yes, the source don't mention “later version”.
Pushed, thanks for review!
prev parent reply other threads:[~2016-03-29 4:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-27 14:02 [PATCH] gnu: Add cgit 宋文武
2016-03-27 14:14 ` 宋文武
2016-03-27 20:49 ` Thompson, David
2016-03-28 10:13 ` 宋文武
2016-03-28 16:31 ` Ludovic Courtès
2016-03-28 16:33 ` Ludovic Courtès
2016-03-29 4:03 ` 宋文武 [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87twjq7wx8.fsf@member.fsf.org \
--to=iyzsong@member.fsf.org \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).