From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mark H Weaver <mhw@netris.org>
Subject: Re: libgd security update / i686 issues
Date: Fri, 29 Jul 2016 16:33:16 -0400
Message-ID: <87twf8kwvn.fsf@netris.org>
References: <20160728072337.GA1011@jasmine> <20160728084049.GB1693@solar>
	<20160728163027.GA10649@jasmine> <877fc5n0db.fsf@netris.org>
	<20160728185606.GA11714@jasmine> <87y44kl40c.fsf@netris.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56959)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1bTETN-0000DV-Nf
	for guix-devel@gnu.org; Fri, 29 Jul 2016 16:33:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1bTETJ-0000VV-MV
	for guix-devel@gnu.org; Fri, 29 Jul 2016 16:33:33 -0400
Received: from world.peace.net ([50.252.239.5]:40438)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1bTETJ-0000VQ-I5
	for guix-devel@gnu.org; Fri, 29 Jul 2016 16:33:29 -0400
In-Reply-To: <87y44kl40c.fsf@netris.org> (Mark H. Weaver's message of "Fri, 29
	Jul 2016 13:59:15 -0400")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel@gnu.org

Mark H Weaver <mhw@netris.org> writes:

> Leo Famulari <leo@famulari.name> writes:
>
>> On Thu, Jul 28, 2016 at 01:22:40PM -0400, Mark H Weaver wrote:
>>> I will adapt my patch to the new version.
>>
>> Unfortunately, this new patch makes libgd fail to build from source on
>> x86_64, like this:
>>
>> gdimagecopyresampled/basic_alpha.c: In function =E2=80=98main=E2=80=99:
>> gdimagecopyresampled/basic_alpha.c:37:23: error: value computed is not u=
sed [-Werror=3Dunused-value]
>>   FLT_EVAL_METHOD !=3D 2 && gdAssertImageEqualsToFile("gdimagecopyresamp=
led/basic_alpha_exp.png", copy);
>>                        ^
>> cc1: all warnings being treated as errors
>> Makefile:3120: recipe for target 'gdimagecopyresampled/basic_alpha.o' fa=
iled
>> make[2]: *** [gdimagecopyresampled/basic_alpha.o] Error 1
>> make[2]: *** Waiting for unfinished jobs....
>> gdimagecopyresampled/bug00201.c: In function =E2=80=98main=E2=80=99:
>> gdimagecopyresampled/bug00201.c:69:26: error: value computed is not used=
 [-Werror=3Dunused-value]
>>      FLT_EVAL_METHOD !=3D 2 && gdAssertImageEqualsToFile("gdimagecopyres=
ampled/bug00201_exp.png", img);
>>                           ^
>> cc1: all warnings being treated as errors
>> Makefile:3120: recipe for target 'gdimagecopyresampled/bug00201.o' failed
>
> Bah, sorry about that.  I just pushed an updated patch that builds
> successfully on x86_64 and i686, and hopefully on the others as well.

The build failed on armhf and mips64el, due to another warning->error
that's unrelated to my patch.  I pushed a possible fix to the
'wip-gd-fix' branch and asked hydra to build it.

      Mark