Re: torsocks 2.0 bug

[ng0 <ng0@we.make.ritual.n0.is>]

A short note to link threads:
It is likely that 2.2.x release will fix the current bug, see
https://lists.gnu.org/archive/html/guix-devel/2016-07/msg01452.html

ng0@we.make.ritual.n0.is writes:

> Hi,
>
> I found this thread while I was deleting old threads.
>
> I worked on torsocks-2.1.0 without knowing there was
> a discussion before. As expected I ran into problems
> too.
>
> The only change I did so far was version bumping, which
> when building torsocks-2.1.0 only fails tests.
>
> This is because our torsocks-2.0 disable dns patch no
> longer works but so far I have found no solution to
> fix it.
>
> Problems appear to be exclusive to tests/unit/test_dns.c ,
> line 59.
> I suggest that whoever wrote the torsocks patch creates
> one for torsocks-2.1.0
>
> Andreas Enge writes:
>
>> On Wed, Feb 03, 2016 at 07:08:32PM +0100, swedebugia@riseup.net wrote:
>>>       '(#:phases (modify-phases %standard-phases
>>> +                  ; FIXME. this phase is still needed but fails. I dont
>>> +                  ; understand why. It works fine when done manually in an
>>> +                  ; environment.
>>>                    (add-before 'configure 'bootstrap
>>>                      (lambda _
>>> -                      (system* "autoreconf" "-vfi"))))))
>>> +                      (system* "autoreconf" "-i")
>>
>> The problem is here. First of all, there was no need to drop the options "v"
>> and "f". But the real problem comes from dropping the parentheses.
>> So now what follows is part of the "lambda" function:
>>
>>> +       ; FIXME. test_fd_passing fail.
>>> +       #:tests? #f)))))
>>
>> And it ends with "#f", so the return value of the function is false, and the
>> phase fails.
>>
>> I tried closing more parentheses, and then the build passes, but the tests
>> still fail. This would need to be investigated more.
>>
>> Andreas
>>
>>


-- 
♥Ⓐ  ng0
Current Keys: https://we.make.ritual.n0.is/ng0.txt
For non-prism friendly talk find me on http://www.psyced.org