From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <rekado@elephly.net>
Subject: Re: [PATCH] Fix compiling on CentOS 7.
Date: Sat, 27 Aug 2016 08:14:40 +0200
Message-ID: <87twe6oi0f.fsf@elephly.net>
References: <87d1kvpazv.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60488)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1bdWtJ-0003wW-AG
	for guix-devel@gnu.org; Sat, 27 Aug 2016 02:14:54 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1bdWtH-0005cn-4c
	for guix-devel@gnu.org; Sat, 27 Aug 2016 02:14:52 -0400
In-reply-to: <87d1kvpazv.fsf@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Roel Janssen <roel@gnu.org>
Cc: guix-devel@gnu.org


Roel Janssen <roel@gnu.org> writes:

> Dear Guix,
>
> Due to an old Automake version (1.13), running the `./configure' phase on
> CentOS 7 fails with:
>
>> autoreconf: running: automake --add-missing --copy --force-missing
>> configure.ac:21: warning: The 'AM_PROG_MKDIR_P' macro is deprecated, and its use is discouraged.
>> configure.ac:21: You should use the Autoconf-provided 'AC_PROG_MKDIR_P' macro instead,
>> configure.ac:21: and use '$(MKDIR_P)' instead of '$(mkdir_p)'in your Makefile.am files.
>> Makefile.am:422: warning: AM_GNU_GETTEXT used but 'po' not in SUBDIRS
>> automake: error: cannot open < ./%D%/guix.texi: No such file or directory
>> autoreconf: automake failed with exit status: 1
>
> (It does not replace %D% with the appropriate directory..)
>
> The attached patch replaces each instance of %D%, which I believe stands
> for the current subdirectory from the project root, with the appropriate
> directory.  With these changes, I've been able to compile GNU Guix on
> CentOS 7.
>
> I am not sure how this change impacts custom configure options, so I
> would like to ask someone with more Automake knowledge and experience to
> elaborate on the possible downsides of applying this patch.
>
> If this change is acceptable to the project, I will update the commit
> message to a more detailed and conforming message.  Suggestions are
> welcome here though.
>
> What do you think about making Guix compilable on this "stable"
> distribution? :-)

Thanks, Roel!  I don’t know much about Automake to say whether there are
any side-effects, so I’ll defer decisions to other people.  To me it
looks innocent.

~~ Ricardo