From: Ricardo Wurmus <rekado@elephly.net>
To: Roel Janssen <roel@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] Fix compiling on CentOS 7.
Date: Sat, 27 Aug 2016 08:14:40 +0200 [thread overview]
Message-ID: <87twe6oi0f.fsf@elephly.net> (raw)
In-Reply-To: <87d1kvpazv.fsf@gnu.org>
Roel Janssen <roel@gnu.org> writes:
> Dear Guix,
>
> Due to an old Automake version (1.13), running the `./configure' phase on
> CentOS 7 fails with:
>
>> autoreconf: running: automake --add-missing --copy --force-missing
>> configure.ac:21: warning: The 'AM_PROG_MKDIR_P' macro is deprecated, and its use is discouraged.
>> configure.ac:21: You should use the Autoconf-provided 'AC_PROG_MKDIR_P' macro instead,
>> configure.ac:21: and use '$(MKDIR_P)' instead of '$(mkdir_p)'in your Makefile.am files.
>> Makefile.am:422: warning: AM_GNU_GETTEXT used but 'po' not in SUBDIRS
>> automake: error: cannot open < ./%D%/guix.texi: No such file or directory
>> autoreconf: automake failed with exit status: 1
>
> (It does not replace %D% with the appropriate directory..)
>
> The attached patch replaces each instance of %D%, which I believe stands
> for the current subdirectory from the project root, with the appropriate
> directory. With these changes, I've been able to compile GNU Guix on
> CentOS 7.
>
> I am not sure how this change impacts custom configure options, so I
> would like to ask someone with more Automake knowledge and experience to
> elaborate on the possible downsides of applying this patch.
>
> If this change is acceptable to the project, I will update the commit
> message to a more detailed and conforming message. Suggestions are
> welcome here though.
>
> What do you think about making Guix compilable on this "stable"
> distribution? :-)
Thanks, Roel! I don’t know much about Automake to say whether there are
any side-effects, so I’ll defer decisions to other people. To me it
looks innocent.
~~ Ricardo
next prev parent reply other threads:[~2016-08-27 6:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-26 19:48 [PATCH] Fix compiling on CentOS 7 Roel Janssen
2016-08-26 23:27 ` ng0
2016-08-27 0:16 ` Roel Janssen
2016-08-27 6:14 ` Ricardo Wurmus [this message]
2016-08-27 6:57 ` Tomáš Čech
2016-08-27 8:39 ` Alex Kost
2016-08-27 8:51 ` Roel Janssen
2016-08-27 10:28 ` Florian Paul Schmidt
2016-08-27 23:33 ` Roel Janssen
2016-08-28 8:11 ` Tomáš Čech
2016-08-28 9:34 ` Efraim Flashner
2016-08-28 9:53 ` Tomáš Čech
2016-08-28 14:13 ` Roel Janssen
2016-08-28 14:42 ` Mathieu Lirzin
2016-08-27 13:06 ` Mathieu Lirzin
2016-08-28 20:11 ` Ludovic Courtès
2016-08-28 20:32 ` Roel Janssen
2016-08-29 12:51 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87twe6oi0f.fsf@elephly.net \
--to=rekado@elephly.net \
--cc=guix-devel@gnu.org \
--cc=roel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).