From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 1/4] gnu: Add python-avro.
Date: Tue, 04 Oct 2016 11:32:44 +0200
Message-ID: <87twcsbgsj.fsf@gnu.org>
References: <20160925211728.7636-1-mbakke@fastmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46336)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1brM5k-0007wk-QM
	for guix-devel@gnu.org; Tue, 04 Oct 2016 05:32:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1brM5g-0004cd-5d
	for guix-devel@gnu.org; Tue, 04 Oct 2016 05:32:52 -0400
In-Reply-To: <20160925211728.7636-1-mbakke@fastmail.com> (Marius Bakke's
	message of "Sun, 25 Sep 2016 22:17:25 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Marius Bakke <mbakke@fastmail.com>
Cc: guix-devel@gnu.org

Hi!

Marius Bakke <mbakke@fastmail.com> skribis:

> * gnu/packages/serialization.scm (avro-version): New variable (private).
> (avro-source): New variable (private).
> (python-avro, python2-avro): New variables.

[...]

> +;;; Avro uses a single source repository for all implementations. The in=
dividual
> +;;; released versions often have missing or incomplete test data, so we =
define
> +;;; the common source here for use in all avro packages.

Two semicolons please.  :-)

> +(define-public python2-avro
> +  (let ((base (package-with-python2 (strip-python2-variant python-avro))=
))
> +    (package (inherit base)
> +             (arguments
> +              `(#:tests? #f ; Requires Apache Ivy.
> +                #:python ,python-2 ; Needed when overriding inherited ar=
gs.
> +                #:phases
> +                (modify-phases %standard-phases
> +                  (add-after 'unpack 'enter-source
> +                    (lambda _ (chdir "lang/py") #t))))))))

Rather:

  (package
    (inherit base)
    (arguments
      (substitute-keyword-arguments (package-arguments python-avro)
        ((#:phases _)
         `(modify-phases %standard-phases
            (add-after 'unpack 'enter-source =E2=80=A6))))))


OK with this change, thanks!

Ludo=E2=80=99.