From mboxrd@z Thu Jan  1 00:00:00 1970
From: Roel Janssen <roel@gnu.org>
Subject: Re: Display diffs between generations.
Date: Tue, 25 Oct 2016 18:01:23 +0200
Message-ID: <87twc08lkc.fsf@gnu.org>
References: <87eg59izmw.fsf@gnu.org> <87d1kry22u.fsf@gnu.org>
	<87inuj5r5v.fsf@gnu.org> <87y43ck6dz.fsf@gnu.org>
	<CAEwRq=rXDW+RpWaZv8eTThuAzeVG+gmmph7EXbpYwgh7qo5a-w@mail.gmail.com>
	<87a8frq0n5.fsf@gnu.org>
	<CAEwRq=prdiTjS9cuMmC9Tf-nHhEL_bBpmuGy8+s_th3HzpwSzw@mail.gmail.com>
	<87lgz78v4d.fsf@gnu.org> <87eg3ogd5l.fsf@gnu.org>
	<87r37nxshp.fsf@gnu.org> <8760opeskj.fsf@gnu.org>
	<87wph43x8x.fsf@gnu.org> <87vawo57sn.fsf@gnu.org>
	<87funrci3f.fsf@gnu.org> <87k2d3p4bf.fsf@gnu.org>
	<87wph2zu8z.fsf@gnu.org> <87oa2eqc03.fsf@gnu.org>
	<20161021164053.2961bd6d@gondolin.arda> <877f8x1o7j.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60811)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <roel@gnu.org>) id 1bz49B-0007KW-Bd
	for guix-devel@gnu.org; Tue, 25 Oct 2016 12:00:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <roel@gnu.org>) id 1bz49A-0005iy-Hs
	for guix-devel@gnu.org; Tue, 25 Oct 2016 12:00:17 -0400
In-reply-to: <877f8x1o7j.fsf@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: guix-devel <guix-devel@gnu.org>


Ludovic Courtès writes:

> Hi!
>
> Benz Schenk <benz.schenk@uzh.ch> skribis:
>
>> On Fri, 21 Oct 2016 11:37:00 +0200
>> Roel Janssen <roel@gnu.org> wrote:
>
> [...]
>
>>> The attached patch implements this behavior.  However, because I use
>>> @code{previous-generation-number} to determine which generation to diff
>>> with, the following will not provide a diff as expected:
>>> 
>>>   guix package --list-generations=42,41,40
>>> 
>>> Any ideas on how to fix this?  Otherwise I'll give it another go over
>>> the weekend.
>>> 
>>> Kind regards,
>>> Roel Janssen
>>
>> I adapted your patch to hopefully implement the desired behaviour, but
>> it might need some cleaning up as I'm just getting started learning
>> scheme.
>
>>From what I can see that Benz’ patch does indeed work as expected (but
> really, the example above is a corner case that we shouldn’t worry too
> much about.)
>
> Roel, if that’s fine with you, please commit with proper commit log and
> acknowledgment.
>
> Thanks to both of you.  :-)

Thanks a lot Benz!

There's only one thing:
Would it make more sense to stick to the chronology of the generations
(sorting them before displaying them)?


If you think Benz's patch is good, then I will push that one.  Otherwise
I'll adapt it to sort the generations.

@Benz, what's the copyright line you want to have in the patch?

Kind regards,
Roel Janssen