[PATCH 0/6] Provide some optional sqlalchemy utils.

[PATCH 0/6] Provide some optional sqlalchemy utils.

[Danny Milosavljevic]

Danny Milosavljevic (6):
  gnu: Add python-pycodestyle.
  gnu: Add python-orderedmultidict.
  gnu: Add python-furl.
  gnu: Add python-flask-babel.
  gnu: Make python-sqlalchemy-utils's existing inputs propagated.
  gnu: Provide pytest to python-sqlalchemy-utils.

 gnu/packages/python.scm | 139 +++++++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 138 insertions(+), 1 deletion(-)

[PATCH 1/6] gnu: Add python-pycodestyle.

[Danny Milosavljevic]

* gnu/packages/python.scm (python-pycodestyle, python2-pycodestyle):
  New variables.
---
 gnu/packages/python.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 518ab3a..cb314e2 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -3829,6 +3829,33 @@ simple and Pythonic domain language.")
 (define-public python2-sqlalchemy
   (package-with-python2 python-sqlalchemy))
 
+(define-public python-pycodestyle
+  (package
+    (name "python-pycodestyle")
+    (version "2.0.0")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (pypi-uri "pycodestyle" version))
+        (sha256
+          (base32
+            "1rz2v8506mdjdyxcnv9ygiw6v0d4dqx8z5sjyjm0w2v32h5l5w1p"))))
+    (build-system python-build-system)
+    (home-page "https://pycodestyle.readthedocs.io/")
+    (synopsis "Python style guide checker")
+    (description "pycodestyle (formerly pep8) is a tool to check your Python code against
+some of the style conventions in @url{http://www.python.org/dev/peps/pep-0008/ PEP 8}.")
+    (license license:expat)
+    (properties `((python2-variant . ,(delay python2-pycodestyle))))))
+
+(define-public python2-pycodestyle
+  (let ((base (package-with-python2 (strip-python2-variant
+                                     python-pycodestyle))))
+    (package (inherit base)
+      (native-inputs
+       `(("python2-setuptools" ,python2-setuptools)
+         ,@(package-native-inputs base))))))
+
 (define-public python-sqlalchemy-utils
   (package
     (name "python-sqlalchemy-utils")

Re: [PATCH 1/6] gnu: Add python-pycodestyle.

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 1982 bytes --]

Danny Milosavljevic <dannym@scratchpost.org> writes:

> * gnu/packages/python.scm (python-pycodestyle, python2-pycodestyle):
>   New variables.
> ---
>  gnu/packages/python.scm | 27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
>
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index 518ab3a..cb314e2 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -3829,6 +3829,33 @@ simple and Pythonic domain language.")
>  (define-public python2-sqlalchemy
>    (package-with-python2 python-sqlalchemy))
>  
> +(define-public python-pycodestyle
> +  (package
> +    (name "python-pycodestyle")
> +    (version "2.0.0")
> +    (source
> +      (origin
> +        (method url-fetch)
> +        (uri (pypi-uri "pycodestyle" version))
> +        (sha256
> +          (base32
> +            "1rz2v8506mdjdyxcnv9ygiw6v0d4dqx8z5sjyjm0w2v32h5l5w1p"))))
> +    (build-system python-build-system)
> +    (home-page "https://pycodestyle.readthedocs.io/")
> +    (synopsis "Python style guide checker")
> +    (description "pycodestyle (formerly pep8) is a tool to check your Python code against
                     ^^^
                     Either capitalize or wrap it in @code{} here.
> +some of the style conventions in @url{http://www.python.org/dev/peps/pep-0008/ PEP 8}.")

I think the @url syntax takes a comma rather than a space.

Otherwise LGTM.

> +    (license license:expat)
> +    (properties `((python2-variant . ,(delay python2-pycodestyle))))))
> +
> +(define-public python2-pycodestyle
> +  (let ((base (package-with-python2 (strip-python2-variant
> +                                     python-pycodestyle))))
> +    (package (inherit base)
> +      (native-inputs
> +       `(("python2-setuptools" ,python2-setuptools)
> +         ,@(package-native-inputs base))))))
> +
>  (define-public python-sqlalchemy-utils
>    (package
>      (name "python-sqlalchemy-utils")

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 454 bytes --]

Re: [PATCH 1/6] gnu: Add python-pycodestyle.

[Efraim Flashner]

[-- Attachment #1: Type: text/plain, Size: 2160 bytes --]

On Sat, Nov 05, 2016 at 12:27:01PM +0100, Danny Milosavljevic wrote:
> * gnu/packages/python.scm (python-pycodestyle, python2-pycodestyle):
>   New variables.
> ---
>  gnu/packages/python.scm | 27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
> 
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index 518ab3a..cb314e2 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -3829,6 +3829,33 @@ simple and Pythonic domain language.")
>  (define-public python2-sqlalchemy
>    (package-with-python2 python-sqlalchemy))
>  
> +(define-public python-pycodestyle
> +  (package
> +    (name "python-pycodestyle")
> +    (version "2.0.0")
> +    (source
> +      (origin
> +        (method url-fetch)
> +        (uri (pypi-uri "pycodestyle" version))
> +        (sha256
> +          (base32
> +            "1rz2v8506mdjdyxcnv9ygiw6v0d4dqx8z5sjyjm0w2v32h5l5w1p"))))
> +    (build-system python-build-system)
> +    (home-page "https://pycodestyle.readthedocs.io/")
> +    (synopsis "Python style guide checker")
> +    (description "pycodestyle (formerly pep8) is a tool to check your Python code against
> +some of the style conventions in @url{http://www.python.org/dev/peps/pep-0008/ PEP 8}.")
> +    (license license:expat)
> +    (properties `((python2-variant . ,(delay python2-pycodestyle))))))
> +
> +(define-public python2-pycodestyle
> +  (let ((base (package-with-python2 (strip-python2-variant
> +                                     python-pycodestyle))))
> +    (package (inherit base)
> +      (native-inputs
> +       `(("python2-setuptools" ,python2-setuptools)
> +         ,@(package-native-inputs base))))))
> +
>  (define-public python-sqlalchemy-utils
>    (package
>      (name "python-sqlalchemy-utils")
> 

Does this package supercede pep8? `guix import pypi pep8' gave me 1.7.0,
so we should switch it out if that's the case

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

Re: [PATCH 1/6] gnu: Add python-pycodestyle.

[Danny Milosavljevic]

Hi,

> Does this package supercede pep8? `guix import pypi pep8' gave me 1.7.0,
> so we should switch it out if that's the case

The request (by Guido van Rossum) can be found at <https://github.com/PyCQA/pycodestyle/issues/466>. So yes, it does.

[PATCH] gnu: Replace python-pep8 by python-pycodestyle.

[Danny Milosavljevic]

* gnu/packages/python.scm (python-pep8, python2-pep8):
  Add replacement.
---
 gnu/packages/python.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 5b5287e..c6ec6d3 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -5645,6 +5645,7 @@ applications.")
 (define-public python-pep8
   (package
     (name "python-pep8")
+    (replacement python-pycodestyle)
     (version "1.7.0")
     (source
       (origin

Re: [PATCH] gnu: Replace python-pep8 by python-pycodestyle.

[Leo Famulari]

On Mon, Nov 07, 2016 at 10:39:50PM +0100, Danny Milosavljevic wrote:
> * gnu/packages/python.scm (python-pep8, python2-pep8):
>   Add replacement.
> ---
>  gnu/packages/python.scm | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index 5b5287e..c6ec6d3 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -5645,6 +5645,7 @@ applications.")
>  (define-public python-pep8
>    (package
>      (name "python-pep8")
> +    (replacement python-pycodestyle)

The grafted replacement system is for packages that have the same binary
interface, and should be used when we must change a package *now* but it
would otherwise require a huge number of rebuilds. That is, for security
updates to core packages.

There aren't very many packages using python-pep8 and python2-pep8, so
we should just make them all use this new package that supersedes
python-pep8.

Re: [PATCH] gnu: Replace python-pep8 by python-pycodestyle.

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 1041 bytes --]

Danny Milosavljevic <dannym@scratchpost.org> writes:

> * gnu/packages/python.scm (python-pep8, python2-pep8):
>   Add replacement.
> ---
>  gnu/packages/python.scm | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index 5b5287e..c6ec6d3 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -5645,6 +5645,7 @@ applications.")
>  (define-public python-pep8
>    (package
>      (name "python-pep8")
> +    (replacement python-pycodestyle)

This will graft python-pycodestyle in place of python-pep8. Are they
fully API compatible?

I think grafting is something that should be reserved for critical
problems affecting a large number of packages, e.g. security fixes for
central libraries. Since there are only 10 direct dependents of pep8
according to `guix refresh -l` (21 rebuilds in total), a "megapatch"
replacing all inputs should be okay.

We should probably also add a "superseded" property to the pep8 package
so any downstream users gets the message.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 454 bytes --]

[PATCH 2/6] gnu: Add python-orderedmultidict.

[Danny Milosavljevic]

* gnu/packages/python.scm (python-orderedmultidict, python2-orderedmultidict):
  New variables.
---
 gnu/packages/python.scm | 42 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 42 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index cb314e2..49c09fc 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -3856,6 +3856,48 @@ some of the style conventions in @url{http://www.python.org/dev/peps/pep-0008/ P
        `(("python2-setuptools" ,python2-setuptools)
          ,@(package-native-inputs base))))))
 
+(define-public python-orderedmultidict
+  (package
+    (name "python-orderedmultidict")
+    (version "0.7.10")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (pypi-uri "orderedmultidict" version))
+        (sha256
+          (base32
+            "1gvqk0jd432wsn88kq4svad68xz3r012jfpnhh9in7bqrkyxidky"))))
+    (build-system python-build-system)
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-after 'unpack 'fix-tests
+           (lambda _
+             ;;The packages uses nosetest for running the tests.
+             ;;Adding this initfile allows to run the test suite
+             ;;without requiring nosetest.
+             (zero? (system* "touch" "tests/__init__.py")))))))
+    (propagated-inputs
+     `(("python-six" ,python-six)))
+    (native-inputs
+     `(("python-pycodestyle" ,python-pycodestyle)))
+    (home-page "https://github.com/gruns/orderedmultidict")
+    (synopsis "Python Ordered Multivalue Dictionary - omdict.")
+    (description "This package contains a library for ordered multivalue dictionaries.
+A multivalue dictionary is a dictionary that can store multiple values for the
+same key. An ordered multivalue dictionary is a multivalue
+dictionary that retains the order of insertions and deletions.")
+    (license license:unlicense)
+    (properties `((python2-variant . ,(delay python2-orderedmultidict))))))
+
+(define-public python2-orderedmultidict
+  (let ((base (package-with-python2 (strip-python2-variant
+                                     python-orderedmultidict))))
+    (package (inherit base)
+      (native-inputs
+       `(("python2-setuptools" ,python2-setuptools)
+         ,@(package-native-inputs base))))))
+
 (define-public python-sqlalchemy-utils
   (package
     (name "python-sqlalchemy-utils")

Re: [PATCH 2/6] gnu: Add python-orderedmultidict.

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 2733 bytes --]

Danny Milosavljevic <dannym@scratchpost.org> writes:

> * gnu/packages/python.scm (python-orderedmultidict, python2-orderedmultidict):
>   New variables.
> ---
>  gnu/packages/python.scm | 42 ++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 42 insertions(+)
>
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index cb314e2..49c09fc 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -3856,6 +3856,48 @@ some of the style conventions in @url{http://www.python.org/dev/peps/pep-0008/ P
>         `(("python2-setuptools" ,python2-setuptools)
>           ,@(package-native-inputs base))))))
>  
> +(define-public python-orderedmultidict
> +  (package
> +    (name "python-orderedmultidict")
> +    (version "0.7.10")
> +    (source
> +      (origin
> +        (method url-fetch)
> +        (uri (pypi-uri "orderedmultidict" version))
> +        (sha256
> +          (base32
> +            "1gvqk0jd432wsn88kq4svad68xz3r012jfpnhh9in7bqrkyxidky"))))
> +    (build-system python-build-system)
> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (add-after 'unpack 'fix-tests
> +           (lambda _
> +             ;;The packages uses nosetest for running the tests.
> +             ;;Adding this initfile allows to run the test suite
> +             ;;without requiring nosetest.
> +             (zero? (system* "touch" "tests/__init__.py")))))))
> +    (propagated-inputs
> +     `(("python-six" ,python-six)))
> +    (native-inputs
> +     `(("python-pycodestyle" ,python-pycodestyle)))
> +    (home-page "https://github.com/gruns/orderedmultidict")
> +    (synopsis "Python Ordered Multivalue Dictionary - omdict.")
> +    (description "This package contains a library for ordered multivalue dictionaries.
> +A multivalue dictionary is a dictionary that can store multiple values for the
> +same key. An ordered multivalue dictionary is a multivalue
           ^^^
Use two spaces between sentences in the description. Or run `guix lint` ;)

Otherwise LGTM.

> +dictionary that retains the order of insertions and deletions.")
> +    (license license:unlicense)
> +    (properties `((python2-variant . ,(delay python2-orderedmultidict))))))
> +
> +(define-public python2-orderedmultidict
> +  (let ((base (package-with-python2 (strip-python2-variant
> +                                     python-orderedmultidict))))
> +    (package (inherit base)
> +      (native-inputs
> +       `(("python2-setuptools" ,python2-setuptools)
> +         ,@(package-native-inputs base))))))
> +
>  (define-public python-sqlalchemy-utils
>    (package
>      (name "python-sqlalchemy-utils")

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 454 bytes --]

[PATCH 3/6] gnu: Add python-furl.

[Danny Milosavljevic]

* gnu/packages/python.scm (python-furl, python2-furl): New variables.
---
 gnu/packages/python.scm | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 49c09fc..3eb33de 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -3898,6 +3898,39 @@ dictionary that retains the order of insertions and deletions.")
        `(("python2-setuptools" ,python2-setuptools)
          ,@(package-native-inputs base))))))
 
+(define-public python-furl
+  (package
+    (name "python-furl")
+    (version "0.5.6")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (pypi-uri "furl" version))
+        (sha256
+          (base32
+            "0lzpfpm686hvz3sr1mcrnd1b3lgmnw8v59gb43wfi98r3b671pqc"))))
+    (build-system python-build-system)
+    (propagated-inputs
+     `(("python-six" ,python-six)
+       ("python-orderedmultidict" ,python-orderedmultidict)))
+    (native-inputs
+     `(("python-pycodestyle" ,python-pycodestyle)))
+    (home-page "https://github.com/gruns/furl")
+    (synopsis "URL manipulation in Python")
+    (description "Python's standard urllib and urlparse modules provide a
+number of URL manipulation functions, but using these functions to perform
+common URL manipulations proves tedious. Furl makes manipulating URLs easy.")
+    (license license:unlicense)
+    (properties `((python2-variant . ,(delay python2-furl))))))
+
+(define-public python2-furl
+  (let ((base (package-with-python2 (strip-python2-variant
+                                     python-furl))))
+    (package (inherit base)
+      (native-inputs
+       `(("python2-setuptools" ,python2-setuptools)
+         ,@(package-native-inputs base))))))
+
 (define-public python-sqlalchemy-utils
   (package
     (name "python-sqlalchemy-utils")

Re: [PATCH 3/6] gnu: Add python-furl.

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 2358 bytes --]

Danny Milosavljevic <dannym@scratchpost.org> writes:

> * gnu/packages/python.scm (python-furl, python2-furl): New variables.
>
> ---
>  gnu/packages/python.scm | 33 +++++++++++++++++++++++++++++++++
>  1 file changed, 33 insertions(+)
>
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index 49c09fc..3eb33de 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -3898,6 +3898,39 @@ dictionary that retains the order of insertions and deletions.")
>         `(("python2-setuptools" ,python2-setuptools)
>           ,@(package-native-inputs base))))))
>  
> +(define-public python-furl
> +  (package
> +    (name "python-furl")
> +    (version "0.5.6")
> +    (source
> +      (origin
> +        (method url-fetch)
> +        (uri (pypi-uri "furl" version))
> +        (sha256
> +          (base32
> +            "0lzpfpm686hvz3sr1mcrnd1b3lgmnw8v59gb43wfi98r3b671pqc"))))
> +    (build-system python-build-system)
> +    (propagated-inputs
> +     `(("python-six" ,python-six)
> +       ("python-orderedmultidict" ,python-orderedmultidict)))
> +    (native-inputs
> +     `(("python-pycodestyle" ,python-pycodestyle)))
> +    (home-page "https://github.com/gruns/furl")
> +    (synopsis "URL manipulation in Python")
> +    (description "Python's standard urllib and urlparse modules provide a
> +number of URL manipulation functions, but using these functions to perform
> +common URL manipulations proves tedious. Furl makes manipulating URLs easy.")

I'm not sure about the description. Why is urllib and urlparse tedious,
and what makes this package better? Perhaps it can be written as "Furl
is an easier-to-use alternative to the @code{urllib} and @code{urlparse}
modules for manipulating URLs.". Or something like that.

Otherwise LGTM.

> +    (license license:unlicense)
> +    (properties `((python2-variant . ,(delay python2-furl))))))
> +
> +(define-public python2-furl
> +  (let ((base (package-with-python2 (strip-python2-variant
> +                                     python-furl))))
> +    (package (inherit base)
> +      (native-inputs
> +       `(("python2-setuptools" ,python2-setuptools)
> +         ,@(package-native-inputs base))))))
> +
>  (define-public python-sqlalchemy-utils
>    (package
>      (name "python-sqlalchemy-utils")

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 454 bytes --]

[PATCH 4/6] gnu: Add python-flask-babel.

[Danny Milosavljevic]

* gnu/packages/python.scm (python-flask-babel, python2-flask-babel):
  New variables.
---
 gnu/packages/python.scm | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 3eb33de..626007e 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -3931,6 +3931,39 @@ common URL manipulations proves tedious. Furl makes manipulating URLs easy.")
        `(("python2-setuptools" ,python2-setuptools)
          ,@(package-native-inputs base))))))
 
+(define-public python-flask-babel
+  (package
+    (name "python-flask-babel")
+    (version "0.11.1")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (pypi-uri "Flask-Babel" version))
+        (sha256
+          (base32
+            "16b80cipdba9xj3jlaiaq6wgrgpjb70w3j01jjy9hbp4k71kd6yj"))))
+    (build-system python-build-system)
+    (propagated-inputs
+     `(("python-flask" ,python-flask)
+       ("python-babel" ,python-babel)
+       ("python-jinja2" ,python-jinja2)
+       ("python-pytz" ,python-pytz)))
+    (home-page "http://github.com/python-babel/flask-babel")
+    (synopsis "Adds i18n/l10n support to Flask applications")
+    (description "Implements internationalization and localization support for Flask.
+This is based on the Python babel module as well as pytz - both of which are installed
+automatically for you if you install this library.")
+    (license license:bsd-3)
+    (properties `((python2-variant . ,(delay python2-flask-babel))))))
+
+(define-public python2-flask-babel
+  (let ((base (package-with-python2 (strip-python2-variant
+                                     python-flask-babel))))
+    (package (inherit base)
+      (native-inputs
+       `(("python2-setuptools" ,python2-setuptools)
+         ,@(package-native-inputs base))))))
+
 (define-public python-sqlalchemy-utils
   (package
     (name "python-sqlalchemy-utils")

Re: [PATCH 4/6] gnu: Add python-flask-babel.

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 151 bytes --]

Danny Milosavljevic <dannym@scratchpost.org> writes:

> * gnu/packages/python.scm (python-flask-babel, python2-flask-babel):
>   New variables.

LGTM.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 454 bytes --]

[PATCH 5/6] gnu: Make python-sqlalchemy-utils's existing inputs propagated.

[Danny Milosavljevic]

* gnu/packages/python.scm (python-sqlalchemy-utils)[arguments]: Make inputs
  propagated.
---
 gnu/packages/python.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 626007e..2d984bb 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -3976,7 +3976,7 @@ automatically for you if you install this library.")
          (base32
           "1zbmmh7n8m01ikizn2mj1mfwch26nsr1awv9mvskqry7av0mpy98"))))
     (build-system python-build-system)
-    (inputs
+    (propagated-inputs
      `(("python-six" ,python-six)
        ("python-sqlalchemy" ,python-sqlalchemy)))
     (home-page "https://github.com/kvesteri/sqlalchemy-utils")

Re: [PATCH 5/6] gnu: Make python-sqlalchemy-utils's existing inputs propagated.

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 129 bytes --]


Nit-pick, but the commit message should be in the following style:

"gnu: python-sqlalchemy-utils: Propagate existing inputs.".

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 454 bytes --]

[PATCH 6/6] gnu: Provide pytest to python-sqlalchemy-utils.

[Danny Milosavljevic]

* gnu/packages/python.scm (python-sqlalchemy-utils)[arguments]: Add pytest.
---
 gnu/packages/python.scm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 2d984bb..86a6eea 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -3979,6 +3979,8 @@ automatically for you if you install this library.")
     (propagated-inputs
      `(("python-six" ,python-six)
        ("python-sqlalchemy" ,python-sqlalchemy)))
+    (native-inputs
+     `(("python-pytest" ,python-pytest)))
     (home-page "https://github.com/kvesteri/sqlalchemy-utils")
     (synopsis "Various utility functions for SQLAlchemy")
     (description

Re: [PATCH 6/6] gnu: Provide pytest to python-sqlalchemy-utils.

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 933 bytes --]

Danny Milosavljevic <dannym@scratchpost.org> writes:

> * gnu/packages/python.scm (python-sqlalchemy-utils)[arguments]: Add pytest.

This is not [arguments], but [native-inputs]. That applies to the
previous patch as well!

> ---
>  gnu/packages/python.scm | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index 2d984bb..86a6eea 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -3979,6 +3979,8 @@ automatically for you if you install this library.")
>      (propagated-inputs
>       `(("python-six" ,python-six)
>         ("python-sqlalchemy" ,python-sqlalchemy)))
> +    (native-inputs
> +     `(("python-pytest" ,python-pytest)))
>      (home-page "https://github.com/kvesteri/sqlalchemy-utils")
>      (synopsis "Various utility functions for SQLAlchemy")
>      (description

Why is this needed now, if it was working before? LGTM anyway.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 454 bytes --]

Re: [PATCH 6/6] gnu: Provide pytest to python-sqlalchemy-utils.

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 1146 bytes --]

On Sat, Nov 05, 2016 at 03:58:16PM +0000, Marius Bakke wrote:
> Danny Milosavljevic <dannym@scratchpost.org> writes:
> 
> > * gnu/packages/python.scm (python-sqlalchemy-utils)[arguments]: Add pytest.
> 
> This is not [arguments], but [native-inputs]. That applies to the
> previous patch as well!
> 
> > ---
> >  gnu/packages/python.scm | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> > index 2d984bb..86a6eea 100644
> > --- a/gnu/packages/python.scm
> > +++ b/gnu/packages/python.scm
> > @@ -3979,6 +3979,8 @@ automatically for you if you install this library.")
> >      (propagated-inputs
> >       `(("python-six" ,python-six)
> >         ("python-sqlalchemy" ,python-sqlalchemy)))
> > +    (native-inputs
> > +     `(("python-pytest" ,python-pytest)))
> >      (home-page "https://github.com/kvesteri/sqlalchemy-utils")
> >      (synopsis "Various utility functions for SQLAlchemy")
> >      (description
> 
> Why is this needed now, if it was working before? LGTM anyway.

It does fail on core-updates:

https://hydra.gnu.org/build/1579077

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

Re: [PATCH 0/6] Provide some optional sqlalchemy utils.

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 626 bytes --]

Danny Milosavljevic <dannym@scratchpost.org> writes:

> Danny Milosavljevic (6):
>   gnu: Add python-pycodestyle.
>   gnu: Add python-orderedmultidict.
>   gnu: Add python-furl.
>   gnu: Add python-flask-babel.
>   gnu: Make python-sqlalchemy-utils's existing inputs propagated.
>   gnu: Provide pytest to python-sqlalchemy-utils.
>
>  gnu/packages/python.scm | 139 +++++++++++++++++++++++++++++++++++++++++++++++-
>  1 file changed, 138 insertions(+), 1 deletion(-)

Hi Danny,

Sorry for the delay, I did not realize that you were not added to the
Guix repo yet. I did the mentioned trivial changes and pushed them.

Thanks!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 454 bytes --]