unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Marius Bakke <mbakke@fastmail.com>
To: Julien Lepiller <julien@lepiller.eu>, guix-devel@gnu.org
Subject: Re: [PATCH] Add php
Date: Sun, 20 Nov 2016 18:02:59 +0100	[thread overview]
Message-ID: <87twb2f5j0.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> (raw)
In-Reply-To: <87polsbqx9.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me>

[-- Attachment #1: Type: text/plain, Size: 1708 bytes --]

Marius Bakke <mbakke@fastmail.com> writes:

>>> > Failures in tests caused by external gd are not too serious to
>>> > require us to switch to the bundled one I think. We may not even
>>> > need to patch our libgd with php specific patches, since the
>>> > failures are only slight deviation from the spec on corner cases.
>>> > If you prefer that we apply these patches too, then we could, and I
>>> > would still try to keep that up to date.
>>> 
>>> OK. Let's use external gd for now barring any serious issues.
>>> 
>>> >
>>> > What I am more worried about are the iconv crashes. That may be due
>>> > to lacking locales though.
>>> 
>>> You could try commenting them out and adding "glibc-locales" to
>>> native-inputs. Not sure if they will get picked up by that however.
>>> 
>>> A better test may be to try out that particular functionality using
>>> the installed version of php. If that works, we can be reasonably
>>> sure that dropping the tests is fine.
>>> 
>>> Attached is the final product, after adding a "gd-for-php" variable
>>> with the two upstream patches, as well as sqlite-3.15.1 (separate
>>> patch).
>>> 
>>> I'll push this tomorrow if there are no further comments. Thanks for
>>> your perseverance :)
>> Just one question: why defining gd-for-php with define, and not
>> define-public?
>
> It's to prevent it from showing up when people are searching for 'gd',
> and also to prevent it from being included by other files.
>
> It's only a temporary measure until the next version is released, so I
> saw no reason to export it.
>
> I'm on my way out, but will commit this tomorrow most likely :-)

Sorry for the delay, PHP is in master now!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 454 bytes --]

  reply	other threads:[~2016-11-20 17:03 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-30 12:08 [PATCH] Add php Julien Lepiller
2016-10-30 14:01 ` Efraim Flashner
2016-10-30 14:03 ` Tobias Geerinckx-Rice
2016-10-30 16:51   ` Julien Lepiller
2016-10-30 22:24     ` Ludovic Courtès
2016-10-30 23:17     ` Marius Bakke
2016-11-02 21:40       ` Julien Lepiller
2016-11-09 15:44         ` Ludovic Courtès
2016-11-11 16:31           ` Julien Lepiller
2016-11-14  9:48             ` Marius Bakke
2016-11-14  9:57               ` Marius Bakke
2016-11-14 12:59                 ` Ludovic Courtès
2016-11-14 13:53                   ` Marius Bakke
2016-11-14 14:46                     ` Ludovic Courtès
2016-11-17  0:01                       ` Marius Bakke
2016-11-17 10:22                         ` Hartmut Goebel
2016-11-17 19:38                           ` Julien Lepiller
2016-11-17 11:08                         ` tyreunom
2016-11-17 12:27                           ` Ludovic Courtès
2016-11-17 18:22                           ` Marius Bakke
2016-11-17 19:34                             ` Julien Lepiller
2016-11-17 20:43                               ` Marius Bakke
2016-11-18 17:25                                 ` Julien Lepiller
2016-11-18 18:09                                   ` Marius Bakke
2016-11-20 17:02                                     ` Marius Bakke [this message]
2016-11-20 17:13                                       ` Leo Famulari
2016-11-21  8:46                                       ` Ludovic Courtès
2016-11-01 17:07 ` Leo Famulari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87twb2f5j0.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me \
    --to=mbakke@fastmail.com \
    --cc=guix-devel@gnu.org \
    --cc=julien@lepiller.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).