From mboxrd@z Thu Jan 1 00:00:00 1970 From: Theodoros Foradis Subject: Re: [PATCH 1/3] gnu: Add xdot. Date: Sun, 01 Jan 2017 20:44:16 +0200 Message-ID: <87tw9i4p6g.fsf@openmailbox.org> References: <20161126142758.25457-1-theodoros.for@openmailbox.org> <20161126142758.25457-2-theodoros.for@openmailbox.org> <87wpfofuzg.fsf@openmailbox.org> <87k2b9chew.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:48399) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cNl7b-00069L-6W for guix-devel@gnu.org; Sun, 01 Jan 2017 13:44:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cNl7Y-0001ke-3Y for guix-devel@gnu.org; Sun, 01 Jan 2017 13:44:43 -0500 Received: from lb1.openmailbox.org ([5.79.108.160]:57088 helo=mail.openmailbox.org) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cNl7X-0001jM-Ql for guix-devel@gnu.org; Sun, 01 Jan 2017 13:44:40 -0500 In-reply-to: <87k2b9chew.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: guix-devel Ludovic Court=C3=A8s writes: > Kei Kebreau skribis: > >> Theodoros Foradis writes: >> >>> * gnu/packages/graphviz.scm (xdot): New variable. > > [...] > >> Other than the comment above, LGTM. Is there someone more experienced >> with Python packages who can double check this? > > If it builds and passes =E2=80=98guix lint=E2=80=99 and looks good to y= ou, please push, > Kei. > > We can always modify it later if we find a problem. > > Thanks! > > Ludo=E2=80=99. Hello, I see that the patch series has not been pushed yet. Do I need to post an updated patch, including the extra configure flag that was suggested? Regards, --=20 Theodoros Foradis