From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: Bad signature on commit 6a34f4ccc8a5d (gnu:
	python-prompt-toolkit: Update to 1.0.9.)
Date: Mon, 02 Jan 2017 21:59:20 +0100
Message-ID: <87tw9hb2l3.fsf@gnu.org>
References: <20161229021015.GA16162@jasmine>
	<3cd2cda0-e1c7-9b6d-b04c-b31302a0fe45@tobias.gr>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41686)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1cO9hY-0006Xk-I5
	for guix-devel@gnu.org; Mon, 02 Jan 2017 15:59:29 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1cO9hU-0000dY-Es
	for guix-devel@gnu.org; Mon, 02 Jan 2017 15:59:28 -0500
In-Reply-To: <3cd2cda0-e1c7-9b6d-b04c-b31302a0fe45@tobias.gr> (Tobias
	Geerinckx-Rice's message of "Thu, 29 Dec 2016 03:49:51 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Tobias Geerinckx-Rice <me@tobias.gr>
Cc: guix-devel@gnu.org

Hello Guix!

Tobias Geerinckx-Rice <me@tobias.gr> skribis:

> On 29/12/16 03:10, Leo Famulari wrote:
>> gpg: BAD signature from "Tobias Geerinckx-Rice <me@tobias.gr>"
>
> Oh dear.
>
>> Does anyone else get the same result? Any ideas?
>
> I do, so it's a real=C2=AE corrupted signature.

It=E2=80=99s a valid signature (gpg parses it correctly):

--8<---------------cut here---------------start------------->8---
$ git cat-file -p 6a34f4ccc8a5d4a48e25ad3c9c512f8634928b91
tree 1fcfe231ee1ee856980ee3e2f055a0d4615c59a6
parent 791ac6a68d1e4bc80f4760cd968cb6c26dbab9ba
author Tobias Geerinckx-Rice <me@tobias.gr> 1482962509 +0100
committer Tobias Geerinckx-Rice <me@tobias.gr> 1482975501 +0100
gpgsig -----BEGIN PGP SIGNATURE-----
=20
 iQEcBAABCgAGBQJYZGkNAAoJEJHM25tIVBuZ+3QH/3wYO1BqGBolMzwD5wI5EVGO
 PBfHnvVBGonNUbuI9F7NwJqYbOeS2Nzd19/h/1T6oMclFCzPfPL5MpPQFnihvSo0
 sPdI+KRtXz4jOJ0WLy+JA65zbKpu84PM0rf0+m8iDA8bRCXIQt1Ym2uYdyIcqUj5
 +sCf6wbnrBhCGTf6t7phWCM3wd166V8L8sIHFhnpxfZRVV2sOGXyunHkcWu8v4/6
 Mf2oaBA08Gq+uCffsbHyqMRr03XhnXprAtaM1eKP0/d7G1nj14lM97mEjr9huGDk
 GKA8F+u3W/7FvaVIN9PhCzSrxzgmdMnVm9q61YB4RmEcBD1E/lG5h8dVOY3eMuI=3D
 =3D/4F2
 -----END PGP SIGNATURE-----

gnu: python-prompt-toolkit: Update to 1.0.9.

* gnu/packages/python.scm (python-prompt-toolkit): Update to 1.0.9.
--8<---------------cut here---------------end--------------->8---

However, it=E2=80=99s a signature against a different piece of data.

It would be good to figure out how that happened.

The pre-push hook that Leo sent runs =E2=80=98git verify-commit=E2=80=99, s=
o it should
catch this kind of problem.

I=E2=80=99m all for adding it to the repo and recommending it in HACKING.

Leo?

But we really need to fix the server-side hook.

Thanks,
Ludo=E2=80=99.