From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] guix archive: '-f docker' supports package names as
	arguments.
Date: Sun, 08 Jan 2017 12:00:51 +0100
Message-ID: <87tw99vmsc.fsf@gnu.org>
References: <87pok12iy5.fsf@gnu.org> <20170106235834.28588-1-ludo@gnu.org>
	<87tw9bcprd.fsf@elephly.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44246)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1cQBDd-0002Vk-3Y
	for guix-devel@gnu.org; Sun, 08 Jan 2017 06:00:58 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1cQBDa-0004xt-3E
	for guix-devel@gnu.org; Sun, 08 Jan 2017 06:00:57 -0500
In-Reply-To: <87tw9bcprd.fsf@elephly.net> (Ricardo Wurmus's message of "Sat,
	07 Jan 2017 08:07:02 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: guix-devel@gnu.org

Hi!

Ricardo Wurmus <rekado@elephly.net> skribis:

> Ludovic Court=C3=A8s <ludo@gnu.org> writes:
>
>> This allows users to type:
>>
>>   guix archive -f docker emacs
>>
>> as was already the case for the 'nar' format.
>>
>> Reported by David Thompson.
>>
>> * guix/scripts/archive.scm (%default-options): Add 'format'.
>> (export-from-store): Dispatch based on the 'format' key in OPTS.
>> (guix-archive): Call 'export-from-store' in all cases when the 'export'
>> key is in OPTS.
>
> Nice, looks good to me!  Thank you.

Thanks, applied.

Other things we could do:

  1. Write the archive to standard output, for consistency with what
     happens with the nar format.

  2. Allow several items to be passed on the command line, as is the
     case with nar exports.  We might need to create a profile
     transparently for this to make sense, but then it becomes more than
     just an archive.

Thoughts?

Ludo=E2=80=99.