Re: [PATCH] gnu: Add perl-parallel-forkmanager.

[Marius Bakke <mbakke@fastmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2023 bytes --]

Ra <ilpuccio.febo@gmail.com> writes:

>     * gnu/packages/perl.scm (perl-parallel-forkmanager): New variable.

Thanks! This looks mostly good, see comments below. Can you send an
updated patch that also includes copyright information? Thanks in
advance!

> ---
>  gnu/packages/perl.scm | 26 ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
>
> diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
> index 8f103ec..532e360 100644
> --- a/gnu/packages/perl.scm
> +++ b/gnu/packages/perl.scm
> @@ -7770,3 +7770,29 @@ interface to File::Find::Object.")
>    (description "Test::TrailingSpace tests for trailing spaces
>  in Perl source files.")
>    (license x11)))
> +
> +(define-public perl-parallel-forkmanager

There is a pledge at the top of perl.scm asking to add packages in
alphabetic order. Can you adjust the location of this expression
accordingly?

> +  (package
> +    (name "perl-parallel-forkmanager")
> +    (version "1.19")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "mirror://cpan/authors/id/Y/YA/YANICK/Parallel-ForkManager-"
> +             version
> +             ".tar.gz"))
> +       (sha256
> +        (base32
> +         "0wm4wp6p3ah5z212jl12728z68nmxmfr0f03z1jpvdzffnc2xppi"))))
> +    (build-system perl-build-system)
> +    (native-inputs
> +     `(("perl-test-warn" ,perl-test-warn)))
> +    (home-page
> +     "http://search.cpan.org/dist/Parallel-ForkManager")
> +    (synopsis
> +     "A simple parallel processing fork manager")

Synopsis should not start with an article. `guix lint` will complain
about this ;-)

Also, the line breaks after home-page and synopsis are not necessary.

> +  (description "Parallel::ForkManager is intended for use in
                   ^^^
                   Please use @code{Parallel::ForkManager} here.

> +operations that can be done in parallel where the number of
> +processes to be forked off should be limited.")
> +  (license (package-license perl))))

Otherwise LGTM!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]